Ports "Fix OD lint errors" #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# About the pull request This PR fixes these messages for the OD lint: ``` Warning OD1002 at code/__pragmas.dm:15:26: Warning 'TooManyArguments' does not exist Error OD0000 at code/datums/global_variables.dm:127:30: attempt to reference r-value Error OD0000 at code/datums/global_variables.dm:369:44: attempt to reference r-value ``` `TooManyArguments` was replaced with `InvalidArgumentCount` which should already be an error. The other two errors are regarding initial not working on globals, which it does not appear to. # Explain why it's good for the game Passing checks is good. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary>  </details> # Changelog No player facing changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Port of "Fix OD lint errors" from main CM: cmss13-devs/cmss13#6566
Explain why it's good for the game
Don't like this:
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
No player-facing changes. All credit to @Drulikar