Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kills weather site overlays #320

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

AmoryBlaine
Copy link
Contributor

I hate the welder/damaged eyes effects on the screen when there's rain or sandstorms. This effectively kills that and replaces it with nothing so you can properly see the screen even during rain and dust storms. Much more visually appealing and I don't have to worry about the downpour gimping the platoon and making a game reliant on sight even harder.

This kills the welder-like overlay placed on the screen during weather instances
code/_onclick/hud/fullscreen.dm Outdated Show resolved Hide resolved
@AndroBetel AndroBetel marked this pull request as draft July 23, 2024 14:22
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@AmoryBlaine AmoryBlaine marked this pull request as ready for review September 14, 2024 03:28
Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also remove the code defining the weather overlays in the first place, as they no longer have a purpose:

//Weather overlays//
/atom/movable/screen/fullscreen/weather
icon_state = "initialize this"
layer = FULLSCREEN_WEATHER_LAYER
appearance_flags = NONE
show_when_dead = TRUE
/atom/movable/screen/fullscreen/weather/low
icon_state = "impairedoverlay1"
/atom/movable/screen/fullscreen/weather/medium
icon_state = "impairedoverlay2"
/atom/movable/screen/fullscreen/weather/high
icon_state = "impairedoverlay3"

code/datums/weather/weather_event.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/sorokyne.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/sorokyne.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/sorokyne.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/new_varadero.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/lv624.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/lv624.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/faction_clash.dm Outdated Show resolved Hide resolved
code/modules/mob/living/living_defense.dm Outdated Show resolved Hide resolved
code/modules/mob/living/living_defense.dm Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants