Fire Support Menu for GM's #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunofang
changed the title
sunofang
changed the title
|
i love this so much it's unreal will give feedback after dis op |
|
no complaints seems as if one gm swapping on the panel changes it for all gm's, though? not a big deal if it's not fixable |
|
Would need to make the vars client specific so it'd need alot of work for little to no gain. |
harryob
previously requested changes
Jul 18, 2024
code/modules/admin/game_master/extra_buttons/fire_support_menu.dm
Outdated
Show resolved
Hide resolved
code/modules/admin/game_master/extra_buttons/fire_support_menu.dm
Outdated
Show resolved
Hide resolved
Co-authored-by: harryob <[email protected]>
Zonespace27
requested changes
Jul 18, 2024
code/modules/admin/game_master/extra_buttons/fire_support_menu.dm
Outdated
Show resolved
Hide resolved
code/modules/admin/game_master/extra_buttons/fire_support_menu.dm
Outdated
Show resolved
Hide resolved
Zonespace27
previously requested changes
Jul 22, 2024
code/modules/admin/game_master/extra_buttons/fire_support_menu.dm
Outdated
Show resolved
Hide resolved
code/modules/admin/game_master/extra_buttons/fire_support_menu.dm
Outdated
Show resolved
Hide resolved
Co-authored-by: Zonespace <[email protected]>
Doubleumc
reviewed
Jul 25, 2024
code/modules/admin/game_master/extra_buttons/fire_support_menu.dm
Outdated
Show resolved
Hide resolved
god damn indentation!!! Co-authored-by: Doubleumc <[email protected]>
Doubleumc
requested changes
Jul 28, 2024
code/modules/admin/game_master/extra_buttons/fire_support_menu.dm
Outdated
Show resolved
Hide resolved
code/modules/admin/game_master/extra_buttons/fire_support_menu.dm
Outdated
Show resolved
Hide resolved
code/modules/admin/game_master/extra_buttons/fire_support_menu.dm
Outdated
Show resolved
Hide resolved
Doubleumc wanted this. Co-authored-by: Doubleumc <[email protected]>
Doubleumc wanted this. Co-authored-by: Doubleumc <[email protected]>
Doubleumc wanted this. Co-authored-by: Doubleumc <[email protected]>
Doubleumc wanted this. Co-authored-by: Doubleumc <[email protected]>
Doubleumc wanted this. Co-authored-by: Doubleumc <[email protected]>
Doubleumc wanted this. Co-authored-by: Doubleumc <[email protected]>
|
One little thing. The fire support menu verb doesnt disappear when you de-admin. Any idea how to fix that? I'd appreciate if someone told me over discord. |
The reason it appears in the first place is you've added the verb to To have it disappear, you'll want to also add it to |
Doubleumc
previously approved these changes
Aug 3, 2024
Doubleumc
dismissed stale reviews from Zonespace27 and harryob
requested changes applied
cm13-github
added a commit
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds a fire support menu to allow game masters to call in various types of ordnance, and make it have the same noises/effects as a normal shot for extra soul.
Explain why it's good for the game
uhh- good for GM's to be able to explode stuff at will.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑
add: Due to budget increases, Close Air Support now has ammo.
admin: Added a fire support menu for GM's to use.
/:cl: