Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special Buck Icon #324

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Special Buck Icon #324

merged 4 commits into from
Jul 18, 2024

Conversation

Meatstuff882
Copy link
Contributor

About the pull request

Adds an icon for special buckshot shells. Thanks to Suno for helping me figure out where to define handful_state.

Explain why it's good for the game

It allows special buckshot to be immediately distinguished from normal buckshot, in the event that both are present. It also looks pretty cool I think.

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑
add: Added an icon for special buckshot.
/:cl:

@@ -82,6 +82,8 @@ var/list/shotgun_boxes_12g = list(
/obj/item/ammo_magazine/shotgun/buckshot/special
name = "box of buckshot shells, USCM special type"
desc = "A box filled with buckshot spread shotgun shells, USCM special type. 12 Gauge."
icon_state = "special"
item_state = "special"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why define both icon and item state? Shouldnt they do the same thing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik item_state in most cases defines inhands sprites, anddd theres no changes to inhands dmi file, might have to add them or change item_state to that of buckshot box

Copy link
Contributor

@AndroBetel AndroBetel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@AndroBetel AndroBetel marked this pull request as draft July 8, 2024 09:34
@Meatstuff882 Meatstuff882 marked this pull request as ready for review July 17, 2024 16:50
@AndroBetel AndroBetel merged commit 9665e1d into cmss13-devs:master Jul 18, 2024
36 checks passed
cm13-github added a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants