Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds infinite weather! #362

Merged
merged 20 commits into from
Aug 25, 2024
Merged

Adds infinite weather! #362

merged 20 commits into from
Aug 25, 2024

Conversation

sunofang
Copy link
Contributor

@sunofang sunofang commented Aug 7, 2024

About the pull request

Adds a few infinite weather (Not technically infinite) options for GM's to use to really set the mood.

Explain why it's good for the game

If you want to do an op set in something like a rainstorm, it gets annoying to restart the weather every 5 minutes.

Testing Photographs and Procedure

Works on my machine after testing on a private server.

Changelog

🆑
admin: Added infinite weather options.
/:cl:

@github-actions github-actions bot added the Admin label Aug 7, 2024
Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For still-not-infinite-but-the-biggest-the-engine-can-handle duration, can use the INFINITY define.
Like so: length = INFINITY

Other than that, looks good to me.

Yippie!
Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INFINITY, not INFINITE.

Otherwise, looks good.

code/datums/weather/weather_events/long.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/long.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/long.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/long.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/long.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/long.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/long.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/long.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/long.dm Outdated Show resolved Hide resolved
code/datums/weather/weather_events/long.dm Outdated Show resolved Hide resolved
Doubleumc
Doubleumc previously approved these changes Aug 22, 2024
Copy link
Contributor

@AndroBetel AndroBetel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AndroBetel AndroBetel enabled auto-merge (squash) August 25, 2024 16:12
@AndroBetel AndroBetel merged commit 393d86c into cmss13-devs:master Aug 25, 2024
35 checks passed
cm13-github added a commit that referenced this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants