Mirror "Spatial Sound Tracking" [WIP] #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stores sound lengths in a json file instead of hardcoding it, also includes the generator for the file
integrate the echo changes
parsing sounds is now the sound_template's job, some more documentation, echo fixes, misc cleanup
minimum bits needed for soundcode parity
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Mirror of cmss13-devs/cmss13#6748
Sound position updates as the hearer and source move around.
Can test merge. Needs to be tested at scale, see if the architecture is appropriate for CM's demands.
Don't full merge. While (hopefully) fully functional its current form is meant to be restrained proof-of-concept before integrating other aspects and touching a ton of files. Tracking playing sounds is a powerful tool that opens up a lot of possibilities, if done in a way the server can handle.
Explain why it's good for the game
More immersive sound effects.
Testing Photographs and Procedure
Screenshots & Videos
as of
minimal hardcode rework port, test 1:as of
minimal hardcode rework port, test 2:as of
minimal hardcode rework port, test 3:as of
minimal hardcode rework port, test 4:Changelog
🆑
soundadd: sounds follow their source
/:cl: