Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lore accurate MD noises #377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lore accurate MD noises #377

wants to merge 1 commit into from
+0 −0

Conversation

DexterDude
Copy link
Contributor

decided not to have the blip when it detects nothing because it doesnt sound as nice

2024-08-14.22-51-37.mp4

@github-actions github-actions bot added the Sound label Aug 15, 2024
Doubleumc
Doubleumc approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Doubleumc Doubleumc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds are fine but be aware this PR is only adding the sounds to the codebase, you don't have them being used anywhere.

@DexterDude
Copy link
Contributor Author

Sounds are fine but be aware this PR is only adding the sounds to the codebase, you don't have them being used anywhere.

They are though? The video shows them being used, they replace the older motion detector noises wholly.

@Doubleumc
Copy link
Contributor

I misread the changed icon as the added icon WHOOPS.
You're right.

@DexterDude
Copy link
Contributor Author

I misread the changed icon as the added icon WHOOPS. You're right.

oops........

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doubleumc Doubleumc Doubleumc approved these changes

Assignees
No one assigned
Labels
Sound
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DexterDude @Doubleumc