Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platoon Leadership Timelocks #387

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

Doubleumc
Copy link
Contributor

About the pull request

Sets timelocks for PltSgt, PltCo to 1 hour squad roles.
Removes all other timelocks.
Ports fix to time duration display.

Note that timelocks are not enabled unless USE_TIMELOCKS is set in config.txt.

Explain why it's good for the game

Prevents brand new players from getting lost in a leadership role of a gamemode they've never experienced before.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added 1 hour squad role timelocks for PltSgt, PltCo
/:cl:

Doubleumc and others added 3 commits August 17, 2024 17:03
set timelock for PltSgt & PltCo to 1 hour, remove timelocks from other squad roles
As of byond 515.1637 time2text's behavior has changed again (see
https://www.byond.com/forum/post/2922387 ). This fixes the timezone
offset used for round time by ensuring time2text is parsing a positive
number since it now treats 0 like it does negative numbers somreason.

Fixes #6381

<details>
<summary>Screenshots & Videos</summary>

![image](https://github.com/cmss13-devs/cmss13/assets/76988376/5ce5aa6f-f66f-424a-8039-b327d45909a1)

</details>

:cl: Drathek
fix: Fixed round time having the wrong timezone offset because of an
engine change to time2text
/:cl:
removing all other timelocks for good measure
@Doubleumc Doubleumc requested a review from fira as a code owner August 17, 2024 21:18
@Doubleumc Doubleumc merged commit ddc100f into cmss13-devs:master Aug 17, 2024
36 checks passed
cm13-github added a commit that referenced this pull request Aug 17, 2024
@Doubleumc Doubleumc deleted the platoon-timelocks branch August 17, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants