Slotting Rework part 1 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK I've decided something about the debug logs in STUI makes neurons fire in my brain in a nice way so I'm keeping them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how jobs are assigned and cycled.
Instead of cycling:
Priorities
Jobs
Players
We now cycle:
Players
Priorities
Jobs
This should stop some of the 4d chess considerations of trying to figure out who is rolling for what and trying to high roll for a slot that has the least people rolling for it.
Now, you just have a (slots available / players readied) chance to get in if you have every job at least low priority.
This will need a good bit of testing (as all slotting changes generally do). As a note, the debug logs will be removed after testing is complete.
More changes to job selection likely coming.