Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the M579 Aerial-Defence System Carrier (AKA, the AA-APC, or LAV-AD of the future) #429

Merged
merged 37 commits into from
Sep 30, 2024

Conversation

BonniePandora
Copy link
Contributor

@BonniePandora BonniePandora commented Sep 3, 2024

About the pull request

Adds a new variant of the APC to the game for GM's to utilise as they see fit, and also offers a flavourful way for marines to down airborne threats such as enemy CAS (via GM intervention and such)

Very much a 'glass cannon' kind of vehicle, capable of dealing a lot of hurt but can't take much punishment in return. Adjustments to damage/range for the weapons is more than doable

Sprites done by Boom on discord largely, with some extrapolated by myself from provided sprites.

Explain why it's good for the game

More things = gooder
Drew inspiration from the tech manual's listed variant of the basic APC, thought it would be neat to add, was a fun code project to work on.
Gives GM's more options for support assets to use as and when they want to too.

Testing Photographs and Procedure

Tested each step of the way on a local server to ensure it worked, no issues besides placeholder sprites for much of the hardpoints.

Screenshots & Videos

image 1

image 1

Changelog

🆑
add: added the M579 ADS-C vehicle
add: added the new weapons, ammo, ammo-storage and viewport console for the above
fix: fixed a typo in the vehicles.dm file whilst I was at it
imageadd: new turf icon added for ADS-C interior
mapadd: added new interior for the M579
/:cl:

Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code good. Just want to see the hardpoint sprites moved to the appropriate file and for it to be tested in at least one operation.

icons/obj/vehicles/movieapc.dmi Outdated Show resolved Hide resolved
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@BonniePandora BonniePandora marked this pull request as draft September 13, 2024 10:48
@BonniePandora
Copy link
Contributor Author

Swapping to a draft until I can get the finished sprites, will address the merge-conflicts & requested changes when that's happened.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

code/modules/vehicles/interior/areas.dm Outdated Show resolved Hide resolved
maps/interiors/apc_aa.dmm Show resolved Hide resolved
Doubleumc
Doubleumc previously approved these changes Sep 24, 2024
@BonniePandora BonniePandora marked this pull request as ready for review September 27, 2024 15:03
@BonniePandora
Copy link
Contributor Author

Sprites are finished at last, ready for a possible TM & review.

code/game/objects/structures/gun_rack.dm Outdated Show resolved Hide resolved
code/modules/vehicles/apc/apc_aa.dm Outdated Show resolved Hide resolved
code/modules/vehicles/apc/apc_aa.dm Outdated Show resolved Hide resolved
code/modules/vehicles/apc/apc_aa.dm Show resolved Hide resolved
code/modules/vehicles/apc/apc_aa.dm Outdated Show resolved Hide resolved
maps/interiors/apc_aa.dmm Show resolved Hide resolved
@Doubleumc Doubleumc dismissed AndroBetel’s stale review September 30, 2024 00:34

All feedback addressed.

@Doubleumc Doubleumc merged commit 9ed6d33 into cmss13-devs:master Sep 30, 2024
36 checks passed
cm13-github added a commit that referenced this pull request Sep 30, 2024
Max-023 pushed a commit to Max-023/PvE-CMSS13 that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants