Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes visors movielike #461

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

AndroBetel
Copy link
Contributor

@AndroBetel AndroBetel commented Sep 19, 2024

image
blue tint, crosshair cursor, accuracy buff, your character faces your mouse at all times
the screenie is a bit off-colored

@BonniePandora
Copy link
Contributor

Feedback after doing a round with this TM'd

  • Film-grain effect was a bit too strong, started to give me a migraine with it active (pref toggle somewhere for the effect?)
  • Armour lights seemed to be a bit broken whilst this was TM'd, they just... Didn't realy light up far?
  • Can't say I noticed the accuracy buff, but the on-screen crosshair was nice, could we get a barebones toggle that offers just that without any of the rest perchance too?

@Doubleumc
Copy link
Contributor

Definitely interesting. For the mouse-facing stuff in particular I understand MouseEntered can be a performance concern, since its not only doing something on the server but also the client has to send a message to the server each time: https://www.byond.com/docs/ref/#/atom/proc/MouseEntered

Its probably not a big deal at our playercount since main CM already has a MouseEntered implementation for the statusbar with no apparent issue: https://github.com/cmss13-devs/cmss13-pve/blob/7c7eaf4490b78a3a811b7c768de7b40af4d26959/code/modules/statusbar/statusbar.dm

However if we're making more serious use of MouseEntered I would like to see a more robust solution. A good example would be this PR which combines MouseEntered performance improvements from TG and a mouse-facing system from Skyrat: shiptest-ss13/Shiptest#2021

At that point though this would be a big enough structural change (and hopefully performant enough) that I'd prefer to see it introduced to main CM and then ported here, to maintain compatibility.

Really I'm just musing aloud. None of this is a requirement.

@AndroBetel AndroBetel marked this pull request as draft September 24, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants