Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US Armed Forces update framework #468

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

BonniePandora
Copy link
Contributor

About the pull request

Adjusts some of the USASF paygrades & defines, along with adding the US Army paygrades.
First part of a planned series of PR's, this is just to get the backend stuff in place before I go on to do gear & equipment/loadout presets.

Explain why it's good for the game

Once complete, this will allow GM's a greater variety of props from different branches of the US armed forces, helping flavour certain maps in different ways.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Adds paygrades of the US Army, along with their rank-pins
code: Changed paygrades of the USASF to actually have paygrade values
/:cl:

Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code good.

Just a note that paygrade ranking is also used for determining if someone's character can have a lisp (low) or a prosthetic (high). With the extra number of ranks in army & navy this pushes the threshold for prosthetics from commissioned officer down to warrant officer. I'm not really concerned, just noting it.

@BonniePandora
Copy link
Contributor Author

Code good.

Just a note that paygrade ranking is also used for determining if someone's character can have a lisp (low) or a prosthetic (high). With the extra number of ranks in army & navy this pushes the threshold for prosthetics from commissioned officer down to warrant officer. I'm not really concerned, just noting it.

Did not know that was effected by it! That said, the threshold for prosthetics doesn't matter here does it given any rank can pick them?
All the same, warrant officers having cybernetics isn't the end of the world, most if not all would be specialists in w.e. profession/trade they work, rather than frontline meat for the grinders

@Doubleumc
Copy link
Contributor

Oh, my mistake: prosthetic restrictions were indeed removed on PvE.

Regardless, was just noting it for future reference since we're not really concerned about rank restrictions on PvE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants