Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner should no longer get stuck on some structures when capture dragging #47

Closed
wants to merge 2 commits into from

Conversation

BeagleGaming1
Copy link
Contributor

About the pull request

Potentially fixes an issue with runner capture dragging pathfinding

Explain why it's good for the game

Bug bad

Changelog

🆑
code: Runners should no longer have pathfinding issues when attempting to capture drag a human
/:cl:

@fira
Copy link
Member

fira commented Nov 4, 2023

I don't think initial() on pass_flags is going to work the way you want, it'd just be null

@morrowwolf morrowwolf marked this pull request as draft November 4, 2023 14:11
@morrowwolf
Copy link
Member

Yeah we talked about on discord, forgot to mention it here

@BeagleGaming1 BeagleGaming1 changed the title Runner pass flags copy dragging Runner should no longer get stuck on some structures when capture dragging Nov 4, 2023
@BeagleGaming1 BeagleGaming1 marked this pull request as ready for review November 4, 2023 16:58
@morrowwolf
Copy link
Member

image
image

Go look at the datum you're manipulating. That var itself isn't bitflags.

@morrowwolf morrowwolf marked this pull request as draft November 4, 2023 18:28
@fira
Copy link
Member

fira commented Nov 4, 2023

You shouldn't manipulate the pass_flags container EVER, it's cached and shared across all instances of the type

That's why you'd traditionally use temp_pass_flags variables

Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Nov 12, 2023
@morrowwolf
Copy link
Member

d55cfcb

@morrowwolf morrowwolf closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants