Skip to content

Commit

Permalink
Fixes Turing Machine UI breaking down if its Smartfridge is exploded (#…
Browse files Browse the repository at this point in the history
…4662)

# About the pull request

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

Just occured on live game - turns out Research can and will explode
themselves (who guessed), and the Turing UI runtimes due to a little
oopsie if there is no associated storage.

I didn't test if this actually broke the UI but a runtime mid ui_data
makes it a safe bet

# Explain why it's good for the game
Freedom to explode things with controlled breakage.

# Testing Photographs and Procedure
Deleted the Smartfridge, pressed Turing buttons.

# Changelog
:cl:
fix: The Turing Machine should now keep working as intended if its
linked Smartfridge is blown up.
/:cl:
  • Loading branch information
fira committed Oct 15, 2023
1 parent 4a5ee47 commit 0065e57
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions code/modules/reagents/chemistry_machinery/autodispenser.dm
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,7 @@
data["multiplier"] = multiplier
data["cycle_limit"] = cycle_limit
data["automode"] = automode
data["linked_storage"] = linked_storage
data["networked_storage"] = linked_storage.is_in_network()
data["networked_storage"] = linked_storage?.is_in_network()
data["smartlink"] = smartlink
data["outputmode"] = outputmode
data["buffervolume"] = reagents.total_volume
Expand Down
1 change: 0 additions & 1 deletion tgui/packages/tgui/interfaces/Autodispenser.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export const Autodispenser = (_props, context) => {
multiplier,
cycle_limit,
automode,
linked_storage,
networked_storage,
smartlink,
outputmode,
Expand Down

0 comments on commit 0065e57

Please sign in to comment.