Skip to content

Commit

Permalink
Fix dropship equipment infinite loop (#5823)
Browse files Browse the repository at this point in the history
# About the pull request

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->
Resolves issue patched by
#5817
# Explain why it's good for the game
Bugs are bad

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
code: removed duplicated signal code from dropship equipment
/:cl:
  • Loading branch information
mullenpaul authored Feb 28, 2024
1 parent a4e6543 commit 187a5fc
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions code/modules/cm_marines/dropship_equipment.dm
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
var/skill_required = SKILL_PILOT_TRAINED
var/combat_equipment = TRUE

/obj/structure/dropship_equipment/Initialize()
. = ..()
RegisterSignal(src, COMSIG_ATOM_DIR_CHANGE, PROC_REF(on_dir_change))

/obj/structure/dropship_equipment/Destroy()
QDEL_NULL(ammo_equipped)
Expand All @@ -37,14 +34,8 @@
if(linked_console.selected_equipment && linked_console.selected_equipment == src)
linked_console.selected_equipment = null
linked_console = null
UnregisterSignal(src, COMSIG_ATOM_DIR_CHANGE)
. = ..()

/obj/structure/dropship_equipment/proc/on_dir_change(datum/source, old_dir, new_dir)
SIGNAL_HANDLER
if(old_dir == new_dir)
return
update_equipment()

/obj/structure/dropship_equipment/attack_alien(mob/living/carbon/xenomorph/current_xenomorph)
if(unslashable)
Expand Down

0 comments on commit 187a5fc

Please sign in to comment.