Skip to content

Commit

Permalink
Removes Unused Stuff (#4835)
Browse files Browse the repository at this point in the history
# About the pull request

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

This just removes unused odds and ends that are still active in repo and
we have to maintain.

Check commit list for a detailed overview. 

What this basically means is it:
- Removes some SS13 Machinery that is unused, mass drivers and such,
making them props
 - Refactors some global-list backed subsystems to use GLOB
- Removes some oldschool subsystems that can be integrated into
processing subsystems
 - Removes completely unused stuff like SSxenocon
 - Removes SSfail_to_topic because it doesn't work on Linux hosts anyway

# Explain why it's good for the game
Less surface to maintain = better maintaining!


# Testing Photographs and Procedure
I just checked game didn't blow up when played.


# Changelog
:cl:
del: Removed unused magnet and mass driver legacy SS13 machinery.
/:cl:
  • Loading branch information
fira authored Nov 6, 2023
1 parent 7628cf9 commit 18cd71a
Show file tree
Hide file tree
Showing 39 changed files with 60 additions and 1,150 deletions.
25 changes: 1 addition & 24 deletions code/__DEFINES/subsystems.dm
Original file line number Diff line number Diff line change
Expand Up @@ -109,36 +109,22 @@
// Subsystems shutdown in the reverse of the order they initialize in
// The numbers just define the ordering, they are meaningless otherwise.

#define SS_INIT_TICKER_SPAWN 999
#define SS_INIT_INPUT 85
#define SS_INIT_FAIL_TO_TOPIC 84
#define SS_INIT_TOPIC 83
#define SS_INIT_LOBBYART 82
#define SS_INIT_RUST 30
#define SS_INIT_INFLUXDRIVER 28
#define SS_INIT_SUPPLY_SHUTTLE 25
#define SS_INIT_GARBAGE 24
#define SS_INIT_EVENTS 23.5
#define SS_INIT_JOB 23
#define SS_INIT_REDIS 22.5
#define SS_INIT_REAGENTS 22.1
#define SS_INIT_MAPPING 22
#define SS_INIT_NIGHTMARE 21.5
#define SS_INIT_TIMETRACK 21.1
#define SS_INIT_HUMANS 21
#define SS_INIT_MAP 20
#define SS_INIT_COMPONENT 19.5
#define SS_INIT_POWER 19
#define SS_INIT_OBJECT 18
#define SS_INIT_PIPENET 17.5
#define SS_INIT_XENOARCH 17
#define SS_INIT_MORE_INIT 16
#define SS_INIT_AIR 15
#define SS_INIT_TELEPORTER 13
#define SS_INIT_INFLUXMCSTATS 12
#define SS_INIT_INFLUXSTATS 11
#define SS_INIT_LIGHTING 10
#define SS_INIT_DEFCON 9
#define SS_INIT_LAW 6
#define SS_INIT_FZ_TRANSITIONS 5
#define SS_INIT_PROJECTILES 4.1
Expand All @@ -152,12 +138,9 @@
#define SS_INIT_RADIO 2
#define SS_INIT_TIMER 100
#define SS_INIT_UNSPECIFIED 0
#define SS_INIT_EMERGENCY_SHUTTLE -19
#define SS_INIT_ASSETS -20
#define SS_INIT_TICKER -21
#define SS_INIT_VOTE -23
#define SS_INIT_FINISH -24
#define SS_INIT_ADMIN -26
#define SS_INIT_DATABASE -27
#define SS_INIT_ENTITYMANAGER -28
#define SS_INIT_PLAYTIME -29
Expand All @@ -176,7 +159,6 @@
#define SS_PRIORITY_SOUND 250
#define SS_PRIORITY_TICKER 200
#define SS_PRIORITY_NIGHTMARE 180
#define SS_PRIORITY_MAPVIEW 170
#define SS_PRIORITY_QUADTREE 160
#define SS_PRIORITY_CHAT 155
#define SS_PRIORITY_STATPANEL 154
Expand All @@ -194,20 +176,16 @@
#define SS_PRIORITY_VOTE 110
#define SS_PRIORITY_FAST_OBJECTS 105
#define SS_PRIORITY_OBJECTS 104
#define SS_PRIORITY_FACEHUGGERS 100
#define SS_PRIORITY_DECORATOR 99
#define SS_PRIORITY_POWER 95
#define SS_PRIORITY_EFFECTS 92
#define SS_PRIORITY_MACHINERY 90
#define SS_PRIORITY_FZ_TRANSITIONS 88
#define SS_PRIORITY_PIPENET 85
#define SS_PRIORITY_ROUND_RECORDING 83
#define SS_PRIORITY_SHUTTLE 80
#define SS_PRIORITY_TELEPORTER 75
#define SS_PRIORITY_EVENT 65
#define SS_PRIORITY_DISEASE 60
#define SS_PRIORITY_FAST_MACHINERY 55
#define SS_PRIORITY_MIDI 40
#define SS_PRIORITY_DEFENSES 55
#define SS_PRIORITY_ENTITY 37
#define SS_PRIORITY_DEFCON 35
#define SS_PRIORITY_ACID_PILLAR 34
Expand All @@ -226,7 +204,6 @@
#define SS_PRIORITY_INFLUXSTATS 8
#define SS_PRIORITY_PLAYTIME 5
#define SS_PRIORITY_PERFLOGGING 4
#define SS_PRIORITY_CORPSESPAWNER 3
#define SS_PRIORITY_GARBAGE 2
#define SS_PRIORITY_INACTIVITY 1
#define SS_PRIORITY_ADMIN 0
Expand Down
3 changes: 0 additions & 3 deletions code/_globalvars/global_lists.dm
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@

var/list/unansweredAhelps = list() //This feels inefficient, but I can't think of a better way. Stores the message indexed by CID

GLOBAL_LIST_EMPTY(PressFaxes)
GLOBAL_LIST_EMPTY(WYFaxes) //Departmental faxes
GLOBAL_LIST_EMPTY(USCMFaxes)
Expand Down
3 changes: 3 additions & 0 deletions code/_globalvars/lists/object_lists.dm
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@ GLOBAL_LIST_EMPTY_TYPED(all_multi_vehicles, /obj/vehicle/multitile)

GLOBAL_LIST_EMPTY_TYPED(lifeboat_almayer_docks, /obj/docking_port/stationary/lifeboat_dock)
GLOBAL_LIST_EMPTY_TYPED(lifeboat_doors, /obj/structure/machinery/door/airlock/multi_tile/almayer/dropshiprear/lifeboat/blastdoor)

GLOBAL_LIST_EMPTY_TYPED(teleporters, /datum/teleporter)
GLOBAL_LIST_EMPTY(teleporters_by_id)
17 changes: 0 additions & 17 deletions code/controllers/configuration/configuration.dm
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
var/policy

var/static/regex/ic_filter_regex
var/list/fail_to_topic_whitelisted_ips

var/is_loaded = FALSE

Expand Down Expand Up @@ -55,7 +54,6 @@
loadmaplist(CONFIG_GROUND_MAPS_FILE, GROUND_MAP)
loadmaplist(CONFIG_SHIP_MAPS_FILE, SHIP_MAP)
LoadChatFilter()
LoadTopicRateWhitelist()

is_loaded = TRUE

Expand Down Expand Up @@ -337,18 +335,3 @@
/datum/controller/configuration/proc/DelayedMessageAdmins(text)
addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(message_admins), text), 0)

/datum/controller/configuration/proc/LoadTopicRateWhitelist()
LAZYINITLIST(fail_to_topic_whitelisted_ips)
if(!fexists("[directory]/topic_rate_limit_whitelist.txt"))
log_config("Error 404: topic_rate_limit_whitelist.txt not found!")
return

log_config("Loading config file topic_rate_limit_whitelist.txt...")

for(var/line in file2list("[directory]/topic_rate_limit_whitelist.txt"))
if(!line)
continue
if(findtextEx(line, "#", 1, 2))
continue

fail_to_topic_whitelisted_ips[line] = 1
40 changes: 0 additions & 40 deletions code/controllers/subsystem/admin.dm

This file was deleted.

11 changes: 4 additions & 7 deletions code/controllers/subsystem/disease.dm
Original file line number Diff line number Diff line change
@@ -1,22 +1,19 @@
var/list/active_diseases = list()


SUBSYSTEM_DEF(disease)
name = "Disease"
wait = 2 SECONDS
flags = SS_NO_INIT | SS_KEEP_TIMING
priority = SS_PRIORITY_DISEASE

var/list/currentrun = list()
var/list/datum/disease/all_diseases = list()
var/list/datum/disease/currentrun = list()

/datum/controller/subsystem/disease/stat_entry(msg)
msg = "P:[active_diseases.len]"
msg = "P:[all_diseases.len]"
return ..()


/datum/controller/subsystem/disease/fire(resumed = FALSE)
if (!resumed)
currentrun = active_diseases.Copy()
currentrun = all_diseases.Copy()

while (currentrun.len)
var/datum/disease/D = currentrun[currentrun.len]
Expand Down
81 changes: 0 additions & 81 deletions code/controllers/subsystem/fail_to_topic.dm

This file was deleted.

27 changes: 0 additions & 27 deletions code/controllers/subsystem/fast_machinery.dm

This file was deleted.

57 changes: 0 additions & 57 deletions code/controllers/subsystem/htmlui.dm

This file was deleted.

Loading

0 comments on commit 18cd71a

Please sign in to comment.