Skip to content

Commit

Permalink
Bump alternative tests to 515.1630 (#5632)
Browse files Browse the repository at this point in the history
# About the pull request

This PR bumps the 515 alternative test to 515.1630 in github checks now
that we have updated the server to that version. It also caused a couple
more hard deletes; one of which (for globals) is sort of a byond issue
but TG had a workaround for it.

# Explain why it's good for the game

Tests should replicate what is used for live.

# Testing Photographs and Procedure

See Checks.

# Changelog

No player facing changes.
  • Loading branch information
Drulikar authored Feb 3, 2024
1 parent aa8ff1a commit 2e71d00
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/alternate_byond_versions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@
# Example:
# 500.1337: runtimestation

515.1610: lv624
515.1630: lv624
6 changes: 5 additions & 1 deletion code/controllers/mc/globals.dm
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ GLOBAL_REAL(GLOB, /datum/controller/global_vars)
GLOB = src

var/datum/controller/exclude_these = new
gvars_datum_in_built_vars = exclude_these.vars + list(NAMEOF(src, gvars_datum_protected_varlist), NAMEOF(src, gvars_datum_in_built_vars), NAMEOF(src, gvars_datum_init_order))
// I know this is dumb but the nested vars list hangs a ref to the datum. This fixes that
var/list/controller_vars = exclude_these.vars.Copy()
controller_vars["vars"] = null
gvars_datum_in_built_vars = controller_vars + list(NAMEOF(src, gvars_datum_protected_varlist), NAMEOF(src, gvars_datum_in_built_vars), NAMEOF(src, gvars_datum_init_order))

QDEL_IN(exclude_these, 0) //signal logging isn't ready

log_world("[vars.len - gvars_datum_in_built_vars.len] global variables")
Expand Down
2 changes: 2 additions & 0 deletions code/game/objects/items/explosives/mine.dm
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,8 @@

/obj/effect/mine_tripwire/Destroy()
if(linked_claymore)
if(linked_claymore.tripwire == src)
linked_claymore.tripwire = null
linked_claymore = null
. = ..()

Expand Down

0 comments on commit 2e71d00

Please sign in to comment.