Skip to content

Commit

Permalink
Hotfixes being able to put anything in your boots (#4845)
Browse files Browse the repository at this point in the history
![](https://cdn.discordapp.com/attachments/862155128441012234/1170748366125277214/dreamseeker_Akwa4enIMm.gif)

# About the pull request

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

Typechecks weren't actually acted upon, letting you put anything in your
boots. Like, anything.
It's funny but it's both breaking things and problematic for balance

# Explain why it's good for the game
Self evident i think

# Testing Photographs and Procedure
Can only put knives in now, as CM Dev intended


# Changelog
:cl:
fix: Fixed being able to put anything in your boots. You're not wizards!
/:cl:
  • Loading branch information
fira authored Nov 6, 2023
1 parent df69bb2 commit 38a22b8
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions code/modules/clothing/clothing.dm
Original file line number Diff line number Diff line change
Expand Up @@ -341,9 +341,13 @@
return
if(stored_item)
return
var/allowed = FALSE
for(var/allowed_item in items_allowed)
if(!istype(attacking_item, allowed_item))
continue
if(istype(attacking_item, allowed_item))
allowed = TRUE
break
if(!allowed)
return
if(!insert_after)
return TRUE
insert_item(user, attacking_item)
Expand Down

0 comments on commit 38a22b8

Please sign in to comment.