Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix minimap removeimage proc not checking z level correctly (#3752)
# About the pull request This PR fixes an issue where the removeimage proc in the minimap subsystem didn't get the turf of the target to correctly test what Z level they were added to such as being deleted in a cryopod. (Entering say a cryopod is not considered a onTransitZ trigger despite the z value changing) # Explain why it's good for the game This PR should fix runtimes such as: ``` [2023-06-28 07:08:53.119] runtime error: /list {len = 5}l"istress Signal"Êß@' - proc name: removeimage (/datum/controller/subsystem/minimaps/proc/removeimage) - source file: minimap.dm,266 - usr: null - src: Minimaps (/datum/controller/subsystem/minimaps) - call stack: - Minimaps (/datum/controller/subsystem/minimaps): removeimage(, Leroy Luna (/mob/living/carbon/human)) - /datum/callback (/datum/callback): Invoke() - Minimaps (/datum/controller/subsystem/minimaps): remove marker(Leroy Luna (/mob/living/carbon/human), null, null) - the marine senior command head... (/obj/item/device/radio/headset/almayer/mcom/cdrcom): dropped(Leroy Luna (/mob/living/carbon/human)) - Leroy Luna (/mob/living/carbon/human): u equip(the marine senior command head... (/obj/item/device/radio/headset/almayer/mcom/cdrcom), the hypersleep chamber (/obj/structure/machinery/cryopod/right), null, null) - Leroy Luna (/mob/living/carbon/human): u equip(the marine senior command head... (/obj/item/device/radio/headset/almayer/mcom/cdrcom), the hypersleep chamber (/obj/structure/machinery/cryopod/right), null, null) - Leroy Luna (/mob/living/carbon/human): u equip(the marine senior command head... (/obj/item/device/radio/headset/almayer/mcom/cdrcom), the hypersleep chamber (/obj/structure/machinery/cryopod/right), null, null) - Leroy Luna (/mob/living/carbon/human): drop inv item to loc(the marine senior command head... (/obj/item/device/radio/headset/almayer/mcom/cdrcom), the hypersleep chamber (/obj/structure/machinery/cryopod/right), null, null) - the hypersleep chamber (/obj/structure/machinery/cryopod/right): despawn occupant() - the hypersleep chamber (/obj/structure/machinery/cryopod/right): process() - Machinery (/datum/controller/subsystem/machinery): fire(0) - Machinery (/datum/controller/subsystem/machinery): ignite(0) - Master (/datum/controller/master): RunQueue() - Master (/datum/controller/master): Loop(2) - Master (/datum/controller/master): StartProcessing(0) ``` # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> ![cryo](https://github.com/cmss13-devs/cmss13/assets/76988376/9ade906e-cde1-4330-9cd7-cc82ffb938e4) </details> # Changelog :cl: Drathek fix: Fix runtimes with minimap subsystem not handling targets inside of objects during removal /:cl:
- Loading branch information