Skip to content

Commit

Permalink
review
Browse files Browse the repository at this point in the history
  • Loading branch information
Git-Nivrak committed Jun 19, 2024
1 parent 01eeb78 commit 50a336c
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 57 deletions.
41 changes: 0 additions & 41 deletions code/datums/effects/xeno_strains/execute_tag.dm

This file was deleted.

10 changes: 2 additions & 8 deletions code/datums/mob_hud.dm
Original file line number Diff line number Diff line change
Expand Up @@ -782,19 +782,13 @@ GLOBAL_DATUM(hud_icon_hudfocus, /image)
holder.icon_state = holo_card_color ? "holo_card_[holo_card_color]" : "hudblank"

// Vampire Execute HUD
/mob/living/carbon/human/proc/update_execute_hud()
/mob/living/carbon/human/proc/update_execute_hud(show)
var/image/execute_holder = hud_list[XENO_EXECUTE]

execute_holder.icon_state = "hudblank"
execute_holder.overlays.Cut()

var/execute_found = FALSE
for (var/datum/effects/execute_tag/ET in effects_list)
if (!QDELETED(ET))
execute_found = TRUE
break

if (execute_found)
if(show)
execute_holder.overlays += image('icons/mob/hud/hud.dmi', src, "prae_tag")

// Xeno "hostile" HUD
Expand Down
18 changes: 18 additions & 0 deletions code/modules/mob/living/carbon/human/human.dm
Original file line number Diff line number Diff line change
Expand Up @@ -1704,3 +1704,21 @@
item.showoff(src)
return TRUE
return ..()

/mob/living/carbon/human/on_knockedout_trait_gain(datum/source)
SIGNAL_HANDLER

Check warning on line 1709 in code/modules/mob/living/carbon/human/human.dm

View workflow job for this annotation

GitHub Actions / Run Linters

Can't define procs SpacemanDMM_should_not_sleep outside their initial definition
. = ..()
if(!length(hud_list[XENO_EXECUTE].overlays))
update_execute_hud(show=TRUE)

return .

/mob/living/carbon/human/on_knockedout_trait_loss(datum/source)
SIGNAL_HANDLER

Check warning on line 1717 in code/modules/mob/living/carbon/human/human.dm

View workflow job for this annotation

GitHub Actions / Run Linters

Can't define procs SpacemanDMM_should_not_sleep outside their initial definition
. = ..()

if(stat != UNCONSCIOUS && length(hud_list[XENO_EXECUTE].overlays))
update_execute_hud(show=FALSE)

return .

11 changes: 4 additions & 7 deletions code/modules/mob/living/carbon/human/life.dm
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,7 @@
if(stat != .)
handle_regular_hud_updates()

for (var/datum/effects/execute_tag/target_tag in src.effects_list)
qdel(target_tag)

if (HAS_TRAIT(src, TRAIT_KNOCKEDOUT) || stat == UNCONSCIOUS)
new /datum/effects/execute_tag(src, src, ttl = 35)

update_execute_hud()
if(stat == UNCONSCIOUS && !length(hud_list[XENO_EXECUTE].overlays))
update_execute_hud(show=TRUE)
else if(!HAS_TRAIT(src, TRAIT_KNOCKEDOUT) && length(hud_list[XENO_EXECUTE].overlays))
update_execute_hud(show=FALSE)
1 change: 0 additions & 1 deletion colonialmarines.dme
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,6 @@
#include "code\datums\effects\stamina\stamina_human.dm"
#include "code\datums\effects\xeno_strains\boiler_trap.dm"
#include "code\datums\effects\xeno_strains\dancer_tag.dm"
#include "code\datums\effects\xeno_strains\execute_tag.dm"
#include "code\datums\effects\xeno_strains\gain_xeno_cooldown_reduction_on_slash.dm"
#include "code\datums\effects\xeno_strains\prae_acid_stacks.dm"
#include "code\datums\effects\xeno_strains\xeno_buff.dm"
Expand Down

0 comments on commit 50a336c

Please sign in to comment.