Skip to content

Commit

Permalink
Remove SSearlyruntimes (#4718)
Browse files Browse the repository at this point in the history
# About the pull request

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

SSearlyruntimes and its PR were introduced to monitor runtimes that
would occur before either the logging globals were ready, or in
development, before the debugger was attached

These have proven to be few and far between, and we now have proper TGS
side server logging to address it. Keeping it only serves the sole case
of local developpers runing into such issues, which is extremely rare.

# Explain why it's good for the game
Trimming out unneeded moving parts

# Testing Photographs and Procedure
Untested

# Changelog
No user facing changes
  • Loading branch information
fira authored Oct 19, 2023
1 parent daa24b7 commit 5925cad
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 20 deletions.
1 change: 0 additions & 1 deletion code/__DEFINES/subsystems.dm
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@
#define SS_INIT_MINIMAP -34
#define SS_INIT_STATPANELS -98
#define SS_INIT_CHAT -100 //Should be last to ensure chat remains smooth during init.
#define SS_INIT_EARLYRUNTIMES -500 // Post-init notifier

// Subsystem fire priority, from lowest to highest priority
// If the subsystem isn't listed here it's either DEFAULT or PROCESS (if it's a processing subsystem child)
Expand Down
14 changes: 0 additions & 14 deletions code/controllers/subsystem/init/earlyruntimes.dm

This file was deleted.

4 changes: 0 additions & 4 deletions code/game/runtimes.dm
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
GLOBAL_REAL(stui_init_runtimes, /list) //! Shorthand of Static Initializer errors only, for use in STUI
GLOBAL_REAL(full_init_runtimes, /list) //! Full text of all Static Initializer + World Init errors, for log backfilling
GLOBAL_REAL_VAR(runtime_logging_ready) //! Truthy when init is done and we don't need these shenanigans anymore
GLOBAL_REAL_VAR(init_runtimes_count) //! Count of runtimes that occured before logging is ready, for in-game reporting

// Deduplication of errors via hash to reduce spamming
GLOBAL_REAL(runtime_hashes, /list)
Expand All @@ -24,16 +23,13 @@ GLOBAL_REAL_VAR(total_runtimes)
if(!total_runtimes)
total_runtimes = 0
total_runtimes += 1
if(!init_runtimes_count)
init_runtimes_count = 0
if(!stui_init_runtimes)
stui_init_runtimes = list()
if(!full_init_runtimes)
full_init_runtimes = list()

// If this occured during early init, we store the full error to write it to world.log when it's available
if(!runtime_logging_ready)
init_runtimes_count += 1
full_init_runtimes += E.desc

// Runtime was already reported once, dedup it for STUI
Expand Down
1 change: 0 additions & 1 deletion colonialmarines.dme
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ s// DM Environment file for colonialmarines.dme.
#include "code\controllers\subsystem\x_evolution.dm"
#include "code\controllers\subsystem\xeno.dm"
#include "code\controllers\subsystem\xenocon.dm"
#include "code\controllers\subsystem\init\earlyruntimes.dm"
#include "code\controllers\subsystem\init\landmarks.dm"
#include "code\controllers\subsystem\init\law.dm"
#include "code\controllers\subsystem\init\lobby_art.dm"
Expand Down

0 comments on commit 5925cad

Please sign in to comment.