-
Notifications
You must be signed in to change notification settings - Fork 523
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes the
do_after()
icon rendering above everything else (#5491)
# About the pull request Fixes the `do_after()` progress icons rendering above *everything* else, including darkness and screen effects like blindness. When making #5379, I didn't consider the side effects of the progress icons being on `ABOVE_HUD_PLANE`. It works fine on other servers where they're usually only visible to the user performing the action, but on CM these icons are visible to everyone. This means that progress indicators over mobs are visible in complete darkness, through crit/blindness overlays, etc. This PR adds a new `ABOVE_GAME_PLANE` define and moves them to that instead, since it seems like the best fit for how the progress icons should behave. (Always above in-game stuff, but below any effects and lighting.) *(I've never messed with plane masters so I'm not 100% sure I did it correctly, but it works in testing at least.)* # Explain why it's good for the game Fixes being able to spot xenos in darkness when they're doing something (e.g. drones building), and just makes it act as expected. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> **Before:** ![(null)scrnshot1](https://github.com/cmss13-devs/cmss13/assets/57483089/079bc397-f658-4954-a1f6-257b6f8d4a9b) (not much point to an 'after' since it's just a black screen lol) </details> # Changelog :cl: fix: Fixed the 'busy' circle icon being drawn above darkness and screen effects. /:cl:
- Loading branch information
Showing
3 changed files
with
25 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters