Skip to content

Commit

Permalink
Mentors can now unmark mhelps (#4747)
Browse files Browse the repository at this point in the history
# About the pull request
Changes the "Mark" button into a "Mark/Unmark" button, allowing mentors
to unmark Mhelps. Ideally Mhelps should get a status tab or UI like
adminhelps, but this is a good-enough stopgap

# Explain why it's good for the game
Unmarking mhelps is a fairly important thing because of all the reasons
why a question may not be answered by the current mentor (AFK,
accidentally clicked, etc.) that can currently only be solved by VV.

# Changelog
:cl:
add: Mentors can now unmark mhelps
/:cl:
  • Loading branch information
Zonespace27 authored Oct 21, 2023
1 parent 3045599 commit 8666c6e
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions code/modules/mentor/mentorhelp.dm
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,7 @@
if(sender == author)
message_title = "MentorHelp"
// If there's a mentor, let them mark it. If not, let them unmark it
if(mentor)
message_sender_options = " (<a href='?src=\ref[src];action=unmark'>Unmark</a>"
else
message_sender_options = " (<a href='?src=\ref[src];action=mark'>Mark</a>"
message_sender_options = " (<a href='?src=\ref[src];action=mark'>Mark/Unmark</a>"
message_sender_options += " | <a href='?src=\ref[src];action=close'>Close</a> | <a href='?src=\ref[src];action=autorespond'>AutoResponse</a>)"

var/message_header = SPAN_MENTORHELP("<span class='prefix'>[message_title] from [message_sender_key]:</span> <span class='message'>[message_sender_options]</span><br>")
Expand Down Expand Up @@ -274,9 +271,10 @@
if("autorespond")
autoresponse(C)
if("mark")
mark(C)
if("unmark")
unmark(C)
if(!mentor)
mark(C)
else
unmark(C)
if("close")
if(C == author || C == mentor || CLIENT_IS_STAFF(C))
close(C)
Expand Down

0 comments on commit 8666c6e

Please sign in to comment.