eek, sdmm didn't pick this up (though it's obvious)

cmss13-devs · Feb 10, 2024 · 9794fee · 9794fee
1 parent c289596
commit 9794fee
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/code/datums/entities/player.dm b/code/datums/entities/player.dm
@@ -317,12 +317,12 @@ BSQL_PROTECT_DATUM(/datum/entity/player)
 	if(banner)
 		permaban_admin_id = banner.id
 		message_admins("[key_name_admin(banner.owning_client)] has permanently banned [ckey] for '[reason]'.")
-		var/datum/tgs_chat_embed/field/reason
+		var/datum/tgs_chat_embed/field/reason_embed
 		if(internal_reason)
-			reason = new()
-			reason.name = "Permaban Reason"
-			reason.value = internal_reason
-		important_message_external("[banner.owning_client] has permanently banned [ckey] for '[reason]'.", "Permaban Placed", list(reason))
+			reason_embed = new()
+			reason_embed.name = "Permaban Reason"
+			reason_embed.value = internal_reason
+		important_message_external("[banner.owning_client] has permanently banned [ckey] for '[reason]'.", "Permaban Placed", reason ? list(reason_embed) : null)
 
 		add_note("Permanently banned | [reason]", FALSE, NOTE_ADMIN, TRUE)
 		if(internal_reason)

diff --git a/code/modules/admin/NewBan.dm b/code/modules/admin/NewBan.dm
@@ -323,7 +323,7 @@ GLOBAL_DATUM(Banlist, /savefile)
 
 	log_admin("STICKYBAN: Identifier: [identifier] Reason: [reason] Message: [message] CKEYs: [english_list(impacted_ckeys)] IPs: [english_list(impacted_ips)] CIDs: [english_list(impacted_cids)]")
 	message_admins("[key_name_admin(src)] has added a new stickyban with the identifier '[identifier]'.")
-	var/datum/tgs_chat_embed/field/reason = new()
-	reason.name = "Stickyban Reason"
-	reason.value = reason
+	var/datum/tgs_chat_embed/field/reason_embed = new()
+	reason_embed.name = "Stickyban Reason"
+	reason_embed.value = reason
 	important_message_external("[src] has added a new stickyban with the identifier '[identifier]'.", "Stickyban Placed", list(reason))