Skip to content

Commit

Permalink
Adds and expands on the descriptions of tank hardpoints & magazins (#…
Browse files Browse the repository at this point in the history
…7398)

# About the pull request

* Adds descriptions in the vehicle vendor to tank hardpoint weapon
options. Giving a small description to how the guns work.
* Gives the magazins and hardpoints item descriptions a more flavorfull
description, being that most where literally placeholders.


# Explain why it's good for the game

Currently you dont really know what the gun does you select for the
tank. Wich is kinda shit.
Your lucky, and finally get to play tank crew for the first time... and
you have no clue what any of the guns do. This should help with that.
Being that, you know, you can now read what the gun does your commiting
to.

Also, a lot of descriptions where 100% placeholders of the items. The
tank is really in dire need of some updates.
So i gave most of them description with some more flavor to them then
just "Its a tank primary".

Also, im kinda unsure what type of changelog this applys to.
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:TheManWithNoHands
add: Added vendor description to: AC3-E autocanon, LTAA-AP Minigun,
DRG-N Flamer, LTB canon, LZR-N Flamer, TOW launcher, M56cupola, and M92T
Grenade Launcher.
add: Expanded the description of: LTAA-AP Minigun, TOW launcher,
M56cupola, M92T Grenade Launcher and the magazins of the AC3-E
autocanon, LTAA-AP Minigun, DRG-N Flamer, LZR-N Flamer, and M92T Grenade
Launcher. As well as for the snowplow hardpoint and heavy and ligth
treads.
/:cl:

---------

Co-authored-by: harryob <[email protected]>
  • Loading branch information
TheManWithNoHands and harryob authored Oct 28, 2024
1 parent 965249c commit a03c4d8
Show file tree
Hide file tree
Showing 14 changed files with 24 additions and 16 deletions.
8 changes: 8 additions & 0 deletions code/game/machinery/vending/vendor_types/crew/vehicle_crew.dm
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ GLOBAL_LIST_INIT(cm_vending_clothing_vehicle_crew, list(

//Not essentials sets but fuck it the code's here
/obj/effect/essentials_set/tank/ltb
desc = "A giant cannon firing explosive 86mm shells. You'd be lucky if this even leaves the dust of whatever you hit with it."
spawned_gear_list = list(
/obj/item/hardpoint/primary/cannon,
/obj/item/ammo_magazine/hardpoint/ltb_cannon,
Expand All @@ -363,20 +364,23 @@ GLOBAL_LIST_INIT(cm_vending_clothing_vehicle_crew, list(
)

/obj/effect/essentials_set/tank/gatling
desc = "A primary LTAA Minigun utilizing AP ammo for tanks. The barrel spins up as it is fired, improving its fire rate and accuracy dramatically. Capable of shredding apart even the thickest walls in seconds."
spawned_gear_list = list(
/obj/item/hardpoint/primary/minigun,
/obj/item/ammo_magazine/hardpoint/ltaaap_minigun,
/obj/item/ammo_magazine/hardpoint/ltaaap_minigun,
)

/obj/effect/essentials_set/tank/dragonflamer
desc = "A heavy flamer that spews out high-combustion napalm in a wide radius. The fuel burns intensely and quickly, which allows for it to be used offensively by armoured vehicles."
spawned_gear_list = list(
/obj/item/hardpoint/primary/flamer,
/obj/item/ammo_magazine/hardpoint/primary_flamer,
/obj/item/ammo_magazine/hardpoint/primary_flamer,
)

/obj/effect/essentials_set/tank/autocannon
desc = "An automatic cannon for tanks, capable of firing precisely even at long ranges. Loads 20mm explosive shells."
spawned_gear_list = list(
/obj/item/hardpoint/primary/autocannon,
/obj/item/ammo_magazine/hardpoint/ace_autocannon,
Expand All @@ -386,25 +390,29 @@ GLOBAL_LIST_INIT(cm_vending_clothing_vehicle_crew, list(
)

/obj/effect/essentials_set/tank/tankflamer
desc = "A small LZR-N Flamer Unit - a modified version of your bog standard flamer."
spawned_gear_list = list(
/obj/item/hardpoint/secondary/small_flamer,
/obj/item/ammo_magazine/hardpoint/secondary_flamer,
)

/obj/effect/essentials_set/tank/tow
desc = "A quint rocket launcher capable of firing four rockets in quick succession."
spawned_gear_list = list(
/obj/item/hardpoint/secondary/towlauncher,
/obj/item/ammo_magazine/hardpoint/towlauncher,
/obj/item/ammo_magazine/hardpoint/towlauncher,
)

/obj/effect/essentials_set/tank/m56cupola
desc = "A permanently fixed M56D, firing standard issue 10x28mm rounds."
spawned_gear_list = list(
/obj/item/hardpoint/secondary/m56cupola,
/obj/item/ammo_magazine/hardpoint/m56_cupola,
)

/obj/effect/essentials_set/tank/tankgl
desc = "A magazine feed grenade launcher capable of holding 10 grenades. This model loads M40 grenades."
spawned_gear_list = list(
/obj/item/hardpoint/secondary/grenade_launcher,
/obj/item/ammo_magazine/hardpoint/tank_glauncher,
Expand Down
2 changes: 1 addition & 1 deletion code/modules/vehicles/hardpoints/armor/snowplow.dm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/hardpoint/armor/snowplow
name = "\improper Snowplow"
desc = "Clears a path in the snow for friendlies"
desc = "Clears a path in the snow for friendlies. It doesn't seem to have much use beyond that."

icon_state = "snowplow"
disp_icon = "tank"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/ammo_magazine/hardpoint/ace_autocannon
name = "Tank Autocannon Magazine"
desc = "A primary armament autocannon magazine"
name = "AC3-E Autocannon Magazine"
desc = "A 40 round magazine holding 20mm shells for the AC3-E autocannon."
caliber = "20mm"
icon_state = "ace_autocannon"
w_class = SIZE_LARGE
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/ammo_magazine/hardpoint/m56_cupola
name = "M56 Cupola Magazine"
desc = "A secondary armament MG magazine"
desc = "A box of 500, 10x28mm caseless tungsten rounds for the M56D heavy machine gun system."
caliber = "10x28mm" //Correlates to smartguns
icon = 'icons/obj/items/weapons/guns/ammo_by_faction/uscm.dmi'
icon_state = "cupola_1"
Expand Down
2 changes: 1 addition & 1 deletion code/modules/vehicles/hardpoints/hardpoint_ammo/gl_ammo.dm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/ammo_magazine/hardpoint/tank_glauncher
name = "M92T Grenade Launcher Magazine"
desc = "A secondary armament grenade magazine."
desc = "A magazine loaded with M40 grenades. Used to reload the magazine fed M92T Grenade launcher."
caliber = "grenade"
icon_state = "glauncher_2"
w_class = SIZE_LARGE
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/obj/item/ammo_magazine/hardpoint/ltaaap_minigun
name = "LTAA-AP Minigun Magazine"
icon = 'icons/obj/items/weapons/guns/ammo_by_faction/uscm.dmi'
desc = "A primary armament minigun magazine."
desc = "A magazine of 7.62x51mm AP ammo for a heavy minigun. Filled to the brim with highly precise armor-penetrating rounds."
caliber = "7.62x51mm" //Correlates to miniguns
icon_state = "ltaa"
w_class = SIZE_LARGE //Primary weapon ammo should probably all be the same w_class
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/ammo_magazine/hardpoint/primary_flamer
name = "DRG-N Offensive Flamer Unit Fuel Tank"
desc = "A primary armament flamethrower magazine."
desc = "Fuel tanks for the DRG-N Offensive Flamer. It contains a high-combustion napalm, capabale of burning through nearly anything."
caliber = "High-Combustion Napalm" //correlates to flamer mags
icon_state = "drgn_flametank"
w_class = SIZE_LARGE
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/ammo_magazine/hardpoint/secondary_flamer
name = "LZR-N Flamer Unit Fuel Tank"
desc = "A secondary armament flamethrower magazine."
desc = "A napalm tank fitted to be accepted by the LZR-N Flamer."
caliber = "UT-Napthal Fuel" //correlates to flamer mags
icon_state = "flametank_large"
w_class = SIZE_LARGE
Expand Down
2 changes: 1 addition & 1 deletion code/modules/vehicles/hardpoints/primary/autocannon.dm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/hardpoint/primary/autocannon
name = "\improper AC3-E Autocannon"
desc = "A primary autocannon for tanks that shoots explosive flak rounds"
desc = "A primary autocannon for tanks that shoots explosive flak rounds."

icon_state = "ace_autocannon"
disp_icon = "tank"
Expand Down
4 changes: 2 additions & 2 deletions code/modules/vehicles/hardpoints/primary/minigun.dm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/hardpoint/primary/minigun
name = "\improper LTAA-AP Minigun"
desc = "A primary weapon for tanks that spews bullets"
desc = "A primary LTAA Minigun utelizing AP ammo for tanks. Its six barrels are heavy and take a bit to fully spin up."

icon_state = "ltaaap_minigun"
disp_icon = "tank"
Expand All @@ -26,7 +26,7 @@
"8" = list(-77, 0)
)

scatter = 18
scatter = 18 //base scatter, modified by stake_delay_mult
gun_firemode = GUN_FIREMODE_AUTOMATIC
gun_firemode_list = list(
GUN_FIREMODE_AUTOMATIC,
Expand Down
2 changes: 1 addition & 1 deletion code/modules/vehicles/hardpoints/secondary/cupola.dm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/hardpoint/secondary/m56cupola
name = "\improper M56 Cupola"
desc = "A secondary weapon for tanks that shoots bullets"
desc = "A secondary weapon for tanks. It's a M56D that was adjusted to be permanently fixed to its mount. You swear you can still see some weld tacks."

icon_state = "m56_cupola"
disp_icon = "tank"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/hardpoint/secondary/grenade_launcher
name = "\improper M92T Grenade Launcher"
desc = "A secondary weapon for tanks that shoots grenades."
desc = "A magazine fed secondary grenade launcher for tanks that shoots M40 grenades."

icon_state = "glauncher"
disp_icon = "tank"
Expand Down
2 changes: 1 addition & 1 deletion code/modules/vehicles/hardpoints/secondary/tow.dm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/hardpoint/secondary/towlauncher
name = "\improper TOW Launcher"
desc = "A secondary weapon for tanks that shoots rockets"
desc = "A secondary weapon for tanks that shoots rockets. It loads multiple rockets at once."

icon_state = "tow_launcher"
disp_icon = "tank"
Expand Down
4 changes: 2 additions & 2 deletions code/modules/vehicles/hardpoints/wheels/treads.dm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/obj/item/hardpoint/locomotion/treads
name = "\improper Treads"
desc = "Integral to the movement of the vehicle."
desc = "Integral to the movement of the vehicle. Steel reinforced rubber tracks, they allow the tank to move faster but in turn need repairs more often."

icon_state = "treads"
disp_icon = "tank"
Expand All @@ -18,7 +18,7 @@

/obj/item/hardpoint/locomotion/treads/robust
name = "\improper Reinforced Treads"
desc = "These treads are made of a tougher material and are more durable. However, the extra weight slows the tank down."
desc = "These treads are made of solid steel plates and are more durable. However, the extra weight slows the tank down."

health = 500
acid_resistant = TRUE
Expand Down

0 comments on commit a03c4d8

Please sign in to comment.