Skip to content

Commit

Permalink
/obj/item/device/suit_cooling_unit removal (#6722)
Browse files Browse the repository at this point in the history
# About the pull request

removes ugly cooling unit that was used ONCE on CORSAT also cleans up
unused proc with it

# Explain why it's good for the game

cleaner code with less remainder of atmos code


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
del: removes /obj/item/device/suit_cooling_unit and
get_pressure_weakness()
/:cl:

---------

Co-authored-by: vincibrv <[email protected]>
  • Loading branch information
cuberound and uuuuhuuuu authored Jul 24, 2024
1 parent ef45f04 commit d334ed3
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 201 deletions.
179 changes: 0 additions & 179 deletions code/game/objects/items/devices/suit_cooling.dm

This file was deleted.

2 changes: 1 addition & 1 deletion code/modules/clothing/spacesuits/spacesuits.dm
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
gas_transfer_coefficient = 0.01
permeability_coefficient = 0.02
flags_armor_protection = BODY_FLAG_CHEST|BODY_FLAG_GROIN|BODY_FLAG_LEGS|BODY_FLAG_FEET|BODY_FLAG_ARMS|BODY_FLAG_HANDS
allowed = list(/obj/item/device/flashlight,/obj/item/tank/emergency_oxygen,/obj/item/device/suit_cooling_unit)
allowed = list(/obj/item/device/flashlight,/obj/item/tank/emergency_oxygen)
slowdown = 3
armor_melee = CLOTHING_ARMOR_NONE
armor_bullet = CLOTHING_ARMOR_NONE
Expand Down
19 changes: 0 additions & 19 deletions code/modules/mob/living/carbon/human/life/life_helpers.dm
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,6 @@
* Mostly for procs that are not called in the direct Life() loop, except for exact functionality matches (handle_breath, breathe, get_breath_from_internal for example)
*/

//Calculate how vulnerable the human is to under- and overpressure.
//Returns 0 (equals 0 %) if sealed in an undamaged suit, 1 if unprotected (equals 100%).
//Suitdamage can modifiy this in 10% steps.
/mob/living/carbon/human/proc/get_pressure_weakness()

var/pressure_adjustment_coefficient = 1 // Assume no protection at first.

if(wear_suit && (wear_suit.flags_inventory & NOPRESSUREDMAGE) && head && (head.flags_inventory & NOPRESSUREDMAGE)) //Complete set of pressure-proof suit worn, assume fully sealed.
pressure_adjustment_coefficient = 0

//Handles breaches in your space suit. 10 suit damage equals a 100% loss of pressure protection.
if(istype(wear_suit, /obj/item/clothing/suit/space))
var/obj/item/clothing/suit/space/S = wear_suit
if(S.can_breach && S.damage)
pressure_adjustment_coefficient += S.damage * 0.1

pressure_adjustment_coefficient = min(1, max(pressure_adjustment_coefficient, 0)) //So it isn't less than 0 or larger than 1.
return pressure_adjustment_coefficient

/mob/living/carbon/human/proc/stabilize_body_temperature()


Expand Down
1 change: 0 additions & 1 deletion colonialmarines.dme
Original file line number Diff line number Diff line change
Expand Up @@ -1140,7 +1140,6 @@
#include "code\game\objects\items\devices\pipe_painter.dm"
#include "code\game\objects\items\devices\portable_vendor.dm"
#include "code\game\objects\items\devices\scanners.dm"
#include "code\game\objects\items\devices\suit_cooling.dm"
#include "code\game\objects\items\devices\taperecorder.dm"
#include "code\game\objects\items\devices\teleportation.dm"
#include "code\game\objects\items\devices\transfer_valve.dm"
Expand Down
1 change: 0 additions & 1 deletion maps/map_files/CORSAT/Corsat.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -24911,7 +24911,6 @@
/area/corsat/sigma/south/complex)
"bTM" = (
/obj/structure/surface/table/reinforced,
/obj/item/device/suit_cooling_unit,
/turf/open/floor/corsat/retrosquareslight,
/area/corsat/sigma/south/complex)
"bTN" = (
Expand Down

0 comments on commit d334ed3

Please sign in to comment.