fix GC deletion issues around reagents

cmss13-devs · Nov 4, 2023 · f6f6fd9 · f6f6fd9
1 parent d9f179d
commit f6f6fd9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/code/game/objects/items/reagent_containers/reagent_container.dm b/code/game/objects/items/reagent_containers/reagent_container.dm
@@ -67,12 +67,6 @@
 	if (N)
 		R.amount_per_transfer_from_this = N
 
-/obj/item/reagent_container/Initialize()
-	. = ..()
-	if (!possible_transfer_amounts)
-		verbs -= /obj/item/reagent_container/verb/set_APTFT //which objects actually uses it?
-	create_reagents(volume)
-
 /obj/item/reagent_container/Destroy()
 	possible_transfer_amounts = null
 	return ..()

diff --git a/code/modules/reagents/Chemistry-Holder.dm b/code/modules/reagents/Chemistry-Holder.dm
@@ -713,5 +713,6 @@
 // Convenience proc to create a reagents holder for an atom
 // Max vol is maximum volume of holder
 /atom/proc/create_reagents(max_vol)
+	QDEL_NULL(reagents)
 	reagents = new/datum/reagents(max_vol)
 	reagents.my_atom = src