Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weed nodes can be placed under walls #3745

Closed
3 tasks done
Time-Warper opened this issue Jun 27, 2023 · 0 comments · Fixed by #3765
Closed
3 tasks done

Weed nodes can be placed under walls #3745

Time-Warper opened this issue Jun 27, 2023 · 0 comments · Fixed by #3765
Labels
Bug Admin events aren't bugs

Comments

@Time-Warper
Copy link

Time-Warper commented Jun 27, 2023 •
edited
Loading

Testmerges

#3601: 'InfluxDB Metrics Backend' by fira
#3298: 'Project ARES - Resurrection' by realforest2001
#3644: 'The weeds are hungry: Bodies for the weeds' by Drulikar
#3676: 'New Varadero revamp' by AnuvKH
#3666: 'Xenos no longer can pull dead xenos' by morrowwolf

Description of the bug

If you build a wall while standing on it as a drone, you can then place a weed node under that wall.

What's the difference with what should have happened?

Usually, when building a wall, it would destroy the weed node under it. But this may bypass the intended feature.

How do we reproduce this bug?

1.Build a wall on yourself.
2.Place a weed node
3.
...

Issue Bingo
@Time-Warper Time-Warper added the Bug Admin events aren't bugs label Jun 27, 2023
@Drulikar Drulikar mentioned this issue Jun 29, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 5, 2023
@Drulikar
Fix Weed Nodes in Walls (#3765)
d4bec12 
# About the pull request

This PR makes it so weed nodes cannot be placed in a turf with density
set true (such as when you build a resin wall on top of yourself) or a
dense structure (such as a window frame). Nodes still can be placed
under doors while they are open. Marked it as balance but feel free to
change it to fix if you think it isn't balance.

If theres a situation where a weed node should be able to be placed in a
turf with density let me know and I can make the check exclusively for
resin walls. I can't think of any though.

# Explain why it's good for the game

Fixes #3745
Fixes #3770 

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/76988376/89b16684-1f35-40f6-81f0-44855f28e732)

</details>

# Changelog
:cl: Drathek
balance: Weed nodes can no longer be placed in walls or window frames
(or any turf or structure with density)
refactor: Refactored the plant weeds ability code
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Weed Nodes in Walls Drulikar/cmss13
1 participant
@Time-Warper