Fix Weed Nodes in Walls #3765
Merged
Fix Weed Nodes in Walls #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring
# Conflicts: # code/modules/mob/living/carbon/xenomorph/abilities/general_powers.dm
harryob
approved these changes
Jun 29, 2023
github-actions
bot
added
Balance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR makes it so weed nodes cannot be placed in a turf with density set true (such as when you build a resin wall on top of yourself) or a dense structure (such as a window frame). Nodes still can be placed under doors while they are open. Marked it as balance but feel free to change it to fix if you think it isn't balance.
If theres a situation where a weed node should be able to be placed in a turf with density let me know and I can make the check exclusively for resin walls. I can't think of any though.
Explain why it's good for the game
Fixes #3745
Fixes #3770
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
balance: Weed nodes can no longer be placed in walls or window frames (or any turf or structure with density)
refactor: Refactored the plant weeds ability code
/:cl: