Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M56D Can be used to clip through walls #3926

Closed
3 tasks done
burrrkeye opened this issue Jul 18, 2023 · 0 comments · Fixed by #3929
Closed
3 tasks done

M56D Can be used to clip through walls #3926

burrrkeye opened this issue Jul 18, 2023 · 0 comments · Fixed by #3929
Labels
Bug Admin events aren't bugs

Comments

@burrrkeye
Copy link

burrrkeye commented Jul 18, 2023 •
edited
Loading

Testmerges

#3676: 'New Varadero revamp' by AnuvKH at commit 22e1d92 #3783: 'Project ARES - Apollo Controller' by realforest2001 at commit 0c6722c #3729: 'Ravager and Hedgehog changes' by GoldenDarkness55 at commit 16b30ac #3850: 'Donator Kits' by realforest2001 at commit 3190146 #3879: 'Yautja Rework Holder' by realforest2001 at commit 442019a #3749: 'Re-balances acid damage' by Diegoflores31 at commit 19f32df #3909: 'Ports TGMC autofire' by Zonespace27 at commit b169937 #3908: 'Changes to squad color code' by BeagleGaming1 at commit 270557f

Description of the bug

You are able to wrench the M56D while manning it, rotating yourself and the gun, you are 1 tile behind the gun, which means, if you place the gun adjacent to a wall and rotate it you are able to clip through the wall and pass over them. You can go into space and probably into places where the area is intended to be inaccassable by all means.

What's the difference with what should have happened?

I believe you should instead be ejected to the tile M56D is in rather than 1 tile behind the handles. You also probably shouldn't be able to rotate the gun with a wrench while you are using it.

How do we reproduce this bug?

  1. Setup your M56D adjacently to a wall, grab the handles.
  2. Equip a wrench and rotate the gun where your character is now on the same tile as the wall.
  3. Unbuckle yourself from the M56D and now you can traverse to the other side of the wall.

Issue Bingo
@burrrkeye burrrkeye added the Bug Admin events aren't bugs label Jul 18, 2023
@Awantje Awantje mentioned this issue Jul 19, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 19, 2023
@Awantje
Fix the M56D ignoring collision when dismounting the user (#3929)
f24a1d1 
# About the pull request

Fixes #3926

It used a force move to dismount from the gun causing these issues. Now,
if you can exit behind you will exit behind the gun.


# Explain why it's good for the game

You could exit into turfs with a density of 1 using this. And you should
not be able to.


# Testing Photographs and Procedure

<details>
<summary>Screenshots & Videos</summary>

Testing it. With cades and a window frame. To ensure it works.
https://imgur.com/a/eT2LBjW

</details>

# Changelog
:cl:
fix: The M56D no longer let's you violate density code when exiting it.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the M56D ignoring collision when dismounting the user Awantje/cmss13
1 participant
@burrrkeye