Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Body bags dont hold burst bodies #3958

Closed
3 tasks done
restedwaves opened this issue Jul 21, 2023 · 1 comment · Fixed by #3964
Closed
3 tasks done

Body bags dont hold burst bodies #3958

restedwaves opened this issue Jul 21, 2023 · 1 comment · Fixed by #3964
Labels
Bug Admin events aren't bugs

Comments

@restedwaves
Copy link

Testmerges

#3783: 'Project ARES - Apollo Controller' by realforest2001 at commit 2390908 #3908: 'Changes to squad color code' by BeagleGaming1 at commit 270557f #3832: 'New CAS Weapon: BLU-200 Dragons Breath, thermobaric bomb' by blackdragonTOW at commit 315dd7b #3939: 'Lesser Drones' by morrowwolf at commit c9583d7 #3950: 'Decreases blood bag IV insertion time' by morrowwolf at commit 45bcdf0 #3931: 'Experimental: Bump rust_g to 2.1.0' by Drulikar at commit c9e4e7e #3955: 'Yautja Rework Holder' by realforest2001 at commit 945cfc9

Description of the bug

upon zipping up a body bag the body is left outside of it
upon bursting i couldnt fit the marine in a body bag, they were dosed with antiparasitic before said bursting.
bag cannot contain live humans. likely intended but eh may aswell note it.

What's the difference with what should have happened?

they should have been able to enter the bag as i zipped it up

How do we reproduce this bug?

1.infect marine
2.let them burst like you secretly wanted to
3.fail to bag their body
...

Issue Bingo
@restedwaves restedwaves added the Bug Admin events aren't bugs label Jul 21, 2023
@DaTruRiZZoB
Copy link

adding to this after testing

bursted bodies CAN be put into a body bag, you just have to wait 5 or so minutes (which is still an issue)

@Drulikar Drulikar mentioned this issue Jul 21, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 24, 2023
@Drulikar
Fix bodybags requiring ToD even if unreviveable (#3964)
b97cd09 
# About the pull request

This PR adjusts the condition to close a mob in a body bag such that
time of death only matters if the mob is reviveable. Also now doesn't
care if a ghost exists or not since they could have just disconnected
temporarily.

# Explain why it's good for the game

Fixes #3958 

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/76988376/8b80e5db-2c16-4580-86c3-0d442a251b53)

</details>

# Changelog
:cl: Drathek
fix: Fix bodybags not accepting warm (recent) dead bodies even if
unreviveable
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bodybags requiring ToD even if unreviveable Drulikar/cmss13
2 participants
@DaTruRiZZoB @restedwaves