Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zombies can modify Sec Records #4309

Closed
3 tasks done
drawsstuff opened this issue Sep 1, 2023 · 6 comments · Fixed by #5313
Closed
3 tasks done

Zombies can modify Sec Records #4309

drawsstuff opened this issue Sep 1, 2023 · 6 comments · Fixed by #5313
Labels
Confirmed Bug We have the same at home!

Comments

@drawsstuff
Copy link

Testmerges

#4246 #4224 #4063 #4290

Description of the bug

Zombies can modify security records

What's the difference with what should have happened?

Undead colonists (lacking ID mind you) should not be able to do this

How do we reproduce this bug?

1.Spawn in as zombie
2.Kill your desired Unga Dunga (in this case I am unable to grab details because my chat log is full of zombies doing push ups
3.Examine them
4.Description should come up, with the relevant "add" button near security records
...

Issue Bingo
@drawsstuff drawsstuff added the Bug Admin events aren't bugs label Sep 1, 2023
@drawsstuff
Copy link
Author

Attaching relevant recording

2023-09-01.16-16-09.mp4

@ghost ghost mentioned this issue Oct 13, 2023
Closed
@Huffie56 Huffie56 added the Needs Reproducing We're not even sure if you know how to do it label Dec 16, 2023
@Huffie56
Copy link
Contributor

Huffie56 commented Dec 16, 2023 •
edited
Loading

can't reproduce it
image

probably was caused because your zombie eyes worked as security HUD....?
probably got fixed without being notified here...
going to let it open for a week ....

@Huffie56 Huffie56 added the Cleanup Flagged This bug is probably not an issue anymore label Dec 16, 2023
@Huffie56 Huffie56 removed the Cleanup Flagged This bug is probably not an issue anymore label Dec 26, 2023
@Huffie56 Huffie56 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2023
@Huffie56
Copy link
Contributor

feel free to tag me if anyone can confirmed the bug as happen recently(current month.)

@Huffie56 Huffie56 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2023
@ghost
Copy link

ghost commented Dec 27, 2023

It's still a bug, the main issue wasn't resolved. Please reopen this ticket.

@ghost
Copy link

ghost commented Dec 27, 2023 •
edited by ghost
Loading

The issue isn't just zombies. If a user puts on hud glasses and then removes them it still displays it. Same thing with medical. Is this intended?

@ghost ghost mentioned this issue Dec 27, 2023
Merged
@Huffie56 Huffie56 reopened this Dec 27, 2023
@Huffie56 Huffie56 added Confirmed Bug We have the same at home! and removed Bug Admin events aren't bugs Needs Reproducing We're not even sure if you know how to do it labels Dec 27, 2023
@Huffie56
Copy link
Contributor

The issue isn't just zombies. If a user puts on hud glasses and then removes them it still displays it. Same thing with medical. Is this intended?

i need more info to respond but if you think their is a more general issue(bug or inconsistency (with the code or in term of logic) with hug glasses you should open an issue for it.
thanks for confirming this bug is real and fixing it.

github-merge-queue bot pushed a commit that referenced this issue Dec 31, 2023
@Drulikar
Fixes zombies being able to use huds / zombie code refactor (#5313)
206bc57 
# About the pull request

Fixes zombies being able to use tech huds, applies to sec, medical and
sl huds.Fixes #4309. Also did a little refactoring for some of the
zombie code while I was at it. There is also another bug which was found
and fixed, basically whenever mobs removed their huds it still displayed
the examine text for that hud type.

# Explain why it's good for the game

my immersion is ruined when I can modify sec records as a zombie.

# Changelog

:cl:
fix: fixes the associated examine text being displayed for different hud
types even when removed.
balance: slightly increases zombie infection rate in dead mobs
refactor: refactored some zombie code. 
/:cl:

---------

Co-authored-by: Drathek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug We have the same at home!
Projects
None yet
Milestone
No milestone
2 participants
@drawsstuff @Huffie56