TGUI / Bugfixes / Improvements: Security Cleanup

[Crowbar764]

About the pull request

• Converts Security Records console to TGUI (inspired by /TG/'s design).
• Fixed printed fingerprint reports run-timing when read.
• Fixed newly created records having incorrect gender casing.
• Fixed the player's wanted status being set to NULL if the SecHud dropdown was cancelled.
• Fixed zombies from being able to modify security records (fixes: Zombies can modify Sec Records #4309).
• Cleaned up the SecHud chat text.
• Cleaned up printed-out data (records, fingerprints, round-start reports).
• Refactors some things for standards and performance.
• Fixed some other bugs I can't remember.

For optimisation, some data is not always accurate when modified from an outside source. I do not want to refresh the data of 100+ players every tick.

Screenshots supplied in the dropdown.

Explain why it's good for the game

Modern UI. Fixes some broken features. Easier to read SecHud

Testing Photographs and Procedure

Screenshots & Videos

Main UI:

Comments tab:

Forensics scanner with prints added (bottom left):

SecHud:

Printed record:

Changelog

🆑 Casper
fix: fixed record-related bugs
ui: added security records TGUI
refactor: cleaned-up SecHud text
/:cl:

[mullenpaul]

Generally looks good - a few small things I feel that should be touched up. I don't know MP well enough to test it all out myself but we can try it on a TM. If you can address the minor issues at some point

[mullenpaul]

would it be possible to use scss rather than hard coded strings?

[Crowbar764]

I can't find anywhere in the code an example of where this has been done before. Are you sure it's possible / better than just using the string like all other components?

[mullenpaul]

I'm not sure a switch case statement is really the way to do this

[Crowbar764]

Changed to if statements.

[ghost]

fix this issue while you're at it, very simple fix. #4309

if(iszombie(user))
    return

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself