Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic medical optic and how it can work without a helmet #4317

Closed
3 tasks done
Artem-fp opened this issue Sep 2, 2023 · 0 comments · Fixed by #4322
Closed
3 tasks done

Basic medical optic and how it can work without a helmet #4317

Artem-fp opened this issue Sep 2, 2023 · 0 comments · Fixed by #4322
Labels
Bug Admin events aren't bugs

Comments

@Artem-fp
Copy link

Artem-fp commented Sep 2, 2023

Testmerges

#4246, #4224, #4063, #4312, #4290

Description of the bug

You can use medhuds without Basic medical optic and even without helmet's.

What's the difference with what should have happened?

I assume screwing Basic medical optic out of helmet would deactivate medhud

How do we reproduce this bug?

  1. Buy Basic medical optic
  2. Put it in helmet
  3. Make it work (use helmet UI)
  4. Get a screwdriver and click on your helmet
  5. Welp, that's it, you can see med status of other marines and yourself without optic AND on top of that other marines can freely use Basic Medical Optic on their helmet and simply produce helmet's with medhud without optic.
  6. Extra step: You can strip helmet after all steps above and still see medhud

Issue Bingo
@Artem-fp Artem-fp added the Bug Admin events aren't bugs label Sep 2, 2023
@morrowwolf morrowwolf mentioned this issue Sep 3, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 4, 2023
@morrowwolf
Fixes perma helmet HUDs (#4322)
010c181 
# About the pull request

Fixes #4317

In the refactor to have all functionality in helmet_visors base it now
requires the active_visor to *not* be the current visor to turn off so
we gotta null active_visor before we turn it off.

# Explain why it's good for the game

Bug bad


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog

:cl: Morrow
fix: Fixed perma helmet HUDs
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes perma helmet HUDs morrowwolf/cmss13
1 participant
@Artem-fp