Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Biolock-Donor Sprite #4398

Closed
3 tasks done
Biolock1 opened this issue Sep 11, 2023 · 0 comments · Fixed by #4400
Closed
3 tasks done

Biolock-Donor Sprite #4398

Biolock1 opened this issue Sep 11, 2023 · 0 comments · Fixed by #4400
Labels
Bug Admin events aren't bugs

Comments

@Biolock1
Copy link

Testmerges

#4379, #4182, #4378

Description of the bug

Donor armor is not showing properly. The helmet is fine.
Screenshot 2023-09-11 163907

What's the difference with what should have happened?

Should show donor armor.x

How do we reproduce this bug?

  1. Spawn "/obj/item/clothing/suit/storage/marine/light/fluff/biolock"

Issue Bingo
@Biolock1 Biolock1 added the Bug Admin events aren't bugs label Sep 11, 2023
@Drulikar Drulikar mentioned this issue Sep 12, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 14, 2023
@Drulikar
Fix fluff type check for map overrides (#4400)
e727e22 
# About the pull request

This PR fixes an issue caused by a path remapping in #4245 where a
typecheck for an old fluff value no longer triggered to prevent map
specific camos on the fluff gear.

Note: NO_SNOW_TYPE is more than just snow, but also not all item types
even perform a test on that flag to prevent calling
select_gamemode_skin.

# Explain why it's good for the game

Fixes #4398 (Or any /obj/item/clothing/suit/storage/marine/light/fluff)

# Changelog
:cl: Drathek
fix: Fix some donor items breaking on maps with camos.
fix: Fix donor items not having a fingerprint atom flag and donor armors
not having conductive atom flag.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fluff type check for map overrides Drulikar/cmss13
1 participant
@Biolock1