-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fluff type check for map overrides #4400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base fluff items should have the NO_SNOW_TYPE flag on flags_atom so it doesn't get a gamemode skin rather than explicitly outlined here.
Agreed
Frustrating SMH |
Obvious solution to that would be to test the flag within the implementations of select_gamemode_skin instead of using it to prevent calling that proc, but I don't know if there was a particular reason why it was done this way in the first place (if I were to guess, to only actually replace sprites for things that should have the sprites). |
About the pull request
This PR fixes an issue caused by a path remapping in #4245 where a typecheck for an old fluff value no longer triggered to prevent map specific camos on the fluff gear.
Note: NO_SNOW_TYPE is more than just snow, but also not all item types even perform a test on that flag to prevent calling select_gamemode_skin.
Explain why it's good for the game
Fixes #4398 (Or any /obj/item/clothing/suit/storage/marine/light/fluff)
Changelog
🆑 Drathek
fix: Fix some donor items breaking on maps with camos.
fix: Fix donor items not having a fingerprint atom flag and donor armors not having conductive atom flag.
/:cl: