Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lesser Drone spawning issue when both pylons in same area #4424

Closed
2 of 3 tasks
Madventurer opened this issue Sep 17, 2023 · 1 comment · Fixed by #4985
Closed
2 of 3 tasks

Lesser Drone spawning issue when both pylons in same area #4424

Madventurer opened this issue Sep 17, 2023 · 1 comment · Fixed by #4985
Labels
Bug Admin events aren't bugs

Comments

@Madventurer
Copy link

Testmerges

The following pull requests are currently test merged: #4379: 'Science Annex Yard Readdition' by c4xmaniac2 at commit f6bedf6 #4378: 'LV Intel Update' by c4xmaniac2 at commit 67b2ec4 #4063: 'Yautja Change Holder' by realforest2001 at commit fcc6c86cd3 #4410: 'Cloaked mobs don't give off visible messages (+cloak logic refactor)' by Zonespace27 at commit 1b5a288 #4391: 'Hijack objectives' by morrowwolf at commit 263df75

Description of the bug

Both pylons are active:
When trying to use the Join as Lesser Drone command, if both pylons are in the same area, the prompt to select which core/pylon to use will automatically highlight both pylons. One of the pylons cannot be joined through, as it defaults to one of them. The other pylon can still be manually clicked to spawn to.

What's the difference with what should have happened?

Both pylons should have separate entries in the spawn location prompt.

How do we reproduce this bug?

  1. Have two comms towers both in the same area
  2. Attempt to Join as Lesser Drone
  3. See image
    ...
    cm-pylon-bug

Issue Bingo
@Madventurer Madventurer added the Bug Admin events aren't bugs label Sep 17, 2023
@Huffie56
Copy link
Contributor

Huffie56 commented Oct 1, 2023

pretty sure the only map where it happen is fiorina sci annex map...?
beside making an area for coms i don't see a quick fix...
image
this could be fix by code or by mapping.

@Birdtalon Birdtalon mentioned this issue Nov 20, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 22, 2023
@Birdtalon
Differentiates pylons in same area when spawning as lesser drone (#4985)
1230191 
# About the pull request

Adds a (1) to duplicate named pylons if they reside in the same area
when trying to spawn at pylon as lesser drone.
Fixes #4424 

# Explain why it's good for the game
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Pylons now differentiated in the input list with a (1) if in the
same area.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Differentiates pylons in same area when spawning as lesser drone Birdtalon/cmss13
2 participants
@Madventurer @Huffie56