Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiates pylons in same area when spawning as lesser drone #4985

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Nov 20, 2023

About the pull request

Adds a (1) to duplicate named pylons if they reside in the same area when trying to spawn at pylon as lesser drone.
Fixes #4424

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Pylons now differentiated in the input list with a (1) if in the same area.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Nov 20, 2023
@morrowwolf
Copy link
Member

(1) (1) instead of iterating, straight to jail

@fira
Copy link
Member

fira commented Nov 20, 2023

Awww yeah you could add proper numbering if doing this

@Birdtalon
Copy link
Contributor Author

So funny story I did actually add numbering which is what I overwrote with the force push after I found I couldn't actually spawn more than 2 pylons in the world.

@morrowwolf
Copy link
Member

It's either 2 or the amount of comms towers, if a map had more than 2 for some reason iunno, something something maintainability, I don't know I don't work here where am I

@Birdtalon
Copy link
Contributor Author

Someone post that quote about maintainability.

@harryob harryob added this pull request to the merge queue Nov 22, 2023
Merged via the queue into cmss13-devs:master with commit 1230191 Nov 22, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 22, 2023
@Birdtalon Birdtalon deleted the lesserspawns branch December 21, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lesser Drone spawning issue when both pylons in same area
4 participants