Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tunnel tracker does not track the tunnel you click on #5529

Closed
3 tasks done
RenaRenaRe opened this issue Jan 24, 2024 · 0 comments · Fixed by #5536
Closed
3 tasks done

Tunnel tracker does not track the tunnel you click on #5529

RenaRenaRe opened this issue Jan 24, 2024 · 0 comments · Fixed by #5536
Labels
Bug Admin events aren't bugs

Comments

@RenaRenaRe
Copy link
Contributor

Testmerges

#5086: 'Adds the XM51 Breaching Scattergun' by VileBeggar at commit 1a300ef #5007: 'Project ARES TM Holder (v4)' by realforest2001 at commit 9ef47f5 #5493: 'React Migration - part 2' by mullenpaul at commit 707f358 #5392: 'Yautja Weapon Gimmicks, Round Two' by realforest2001 at commit bcd8b2b #5490: 'Requisition Centralization [Part 1]' by ItsVyzo at commit f756754 #5525: 'Fix Weird Inventories' by Drulikar at commit 4787757 #5515: 'Nerfs GAU damage by one fifth.' by Birdtalon at commit 3586ae2

Round ID

20529 and 20530

Description of the bug

If you alt click the queen locator you can switch it to track a tunnel. However if you try to track a tunnel it will not necessarily track the tunnel you clicked on and will instead track a different tunnel. It seems like it's due to #5465, I think if you try to track the furthest tunnel away from you (the last in the list) it will instead track the most recently created tunnel (what used to be the last in the list before that PR).

What's the difference with what should have happened?

Tracking a tunnel should actually track that tunnel.

How do we reproduce this bug?

  1. Be a xeno
  2. Track a tunnel
  3. Notice that it does not actually point to the correct tunnel

Issue Bingo
@RenaRenaRe RenaRenaRe added the Bug Admin events aren't bugs label Jan 24, 2024
@SabreML SabreML mentioned this issue Jan 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 26, 2024
@SabreML
Fixes xeno tunnel tracking (#5536)
7e13948 
# About the pull request

I swear I do actually test my PRs 😢.

Fixes #5529 by refactoring the 'Queen locator' to track targets with
`/datum/weakref`s, rather than their index in a global list.

# Explain why it's good for the game

Bugfix. (Honestly no idea how I missed this one)

It makes the code much simpler and easier to understand (arguably).

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


https://github.com/cmss13-devs/cmss13/assets/57483089/97552c21-c28a-49a8-a4aa-6ff03209062e

</details>


# Changelog
:cl:
fix: Fixed the xeno 'queen locator' giving the wrong location when a
tunnel was selected.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes xeno tunnel tracking SabreML/cmss13
1 participant
@RenaRenaRe