Fixes xeno tunnel tracking #5536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 987290f.
|
I haven't quite finished testing this one yet since I had to prepare food (I melted a spatula!), so it's drafted for a little while. |
I misunderstood how the `xeno_leader_list` works. (It isn't associative, just fixed length.)
Drulikar
requested changes
Jan 24, 2024
Plus a fix for if someone got de-leadered
Rather than the tracker going blank for one life tick if it can't find `tracking_atom`, this makes it immediately swap to the queen.
3 tasks
Drulikar
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
I swear I do actually test my PRs 😢.
Fixes #5529 by refactoring the 'Queen locator' to track targets with
/datum/weakrefs, rather than their index in a global list.Explain why it's good for the game
Bugfix. (Honestly no idea how I missed this one)
It makes the code much simpler and easier to understand (arguably).
Testing Photographs and Procedure
Screenshots & Videos
dreamseeker_AZGhRTwynV.mp4
Changelog
🆑
fix: Fixed the xeno 'queen locator' giving the wrong location when a tunnel was selected.
/:cl: