Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigRed is missing some landmarks for nightmare inserts #5558

Closed
2 of 3 tasks
Drulikar opened this issue Jan 26, 2024 · 2 comments · Fixed by #5796
Closed
2 of 3 tasks

BigRed is missing some landmarks for nightmare inserts #5558

Drulikar opened this issue Jan 26, 2024 · 2 comments · Fixed by #5796
Labels
Confirmed Bug We have the same at home! Mapping did you remember to save in tgm format?

Comments

@Drulikar
Copy link
Contributor

Testmerges

#5086 at 1a300ef, #5392 at bcd8b2b, #5452 at 830526a, #5536 at 9368476, #5526 at c2a1fce, #5506 at 745cc5b

Round ID

20572

Description of the bug

Some landmarks, maybe more than just these, are missing/named incorrectly for nightmare inserts/sprinkles in the Solaris Ridge map.

DEBUG: Nightmare Mapload: Could not find landmark: vault
DEBUG: Nightmare Mapload: Could not find landmark: containerroom

What's the difference with what should have happened?

All nightmares should be able to be loaded if they are intended to exist (otherwise delete them)

How do we reproduce this bug?

  1. Optionally increase the probability nightmare sprinkle of 25.containerroom_xenos.dmm to 100.containerroom_xenos.dmm and 25.vault_v2.dmm to 100.vault_v2.dmm
  2. Launch game on Solaris Ridge / Big Red
  3. Note debug messages when round starts as nightmares load

Issue Bingo
@Drulikar Drulikar added the Bug Admin events aren't bugs label Jan 26, 2024
@Huffie56 Huffie56 self-assigned this Jan 28, 2024
@Huffie56 Huffie56 added Mapping did you remember to save in tgm format? Confirmed Bug We have the same at home! labels Jan 28, 2024
@Huffie56 Huffie56 removed their assignment Jan 28, 2024
@Huffie56 Huffie56 removed the Bug Admin events aren't bugs label Jan 28, 2024
@Huffie56
Copy link
Contributor

changing the name doesn't work... no idea why it's not working...
while checking it i found this insert cave-north_lambdapath that didn't have an insert on the map and did show up on debug the same way as the other two

@Huffie56
Copy link
Contributor

could it be because of that PR #1371
didn't check yet

@Drulikar Drulikar mentioned this issue Feb 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 29, 2024
@Drulikar
Nightmare Insert Fixes & Elevated Nightmare Errors (#5796)
5bdc65d 
# About the pull request

This PR elevates nightmare insert errors to a runtime so they fail
checks and corrects errors, removes, or properly disables inserts that
were causing the errors in the first place.

# Explain why it's good for the game

Fixes #5558 Various nightmares were not loading because of issues; this
should restore various nightmares.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/76988376/5d883704-806b-4d32-8b21-82bad7eebac7)

</details>


# Changelog
:cl: Drathek BadAtThisGame
maptweak: Fixed various nightmare inserts that were not spawning;
removing or disabling others that were not in use.
maptweak: Updated containerroom_xenos insert for Solaris Ridge to
include coms tower (BadAtThisGame)
code: Nightmare errors are now a runtime.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug We have the same at home! Mapping did you remember to save in tgm format?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nightmare Insert Fixes & Elevated Nightmare Errors Drulikar/cmss13
2 participants
@Drulikar @Huffie56