Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightmare Insert Fixes & Elevated Nightmare Errors #5796

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Feb 23, 2024

About the pull request

This PR elevates nightmare insert errors to a runtime so they fail checks and corrects errors, removes, or properly disables inserts that were causing the errors in the first place.

Explain why it's good for the game

Fixes #5558 Various nightmares were not loading because of issues; this should restore various nightmares.

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑 Drathek BadAtThisGame
maptweak: Fixed various nightmare inserts that were not spawning; removing or disabling others that were not in use.
maptweak: Updated containerroom_xenos insert for Solaris Ridge to include coms tower (BadAtThisGame)
code: Nightmare errors are now a runtime.
/:cl:

@github-actions github-actions bot added Fix Fix one bug, make ten more Code Improvement Make the code longer labels Feb 23, 2024
Update landmark names
Fully remove two previously removed inserts
@Drulikar Drulikar added the Mapping did you remember to save in tgm format? label Feb 24, 2024
@Drulikar Drulikar marked this pull request as ready for review February 24, 2024 04:26
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping be fine and fly

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Feb 24, 2024
@Drulikar
Copy link
Contributor Author

Can confirm the coms will spawn in the restored insert just fine.
image

@harryob harryob added this pull request to the merge queue Feb 29, 2024
Merged via the queue into cmss13-devs:master with commit 5bdc65d Feb 29, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 29, 2024
@Drulikar Drulikar deleted the Elevate_Nightmare_Errors branch March 1, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Fix Fix one bug, make ten more Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigRed is missing some landmarks for nightmare inserts
3 participants