-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightmare Insert Fixes & Elevated Nightmare Errors #5796
Merged
harryob
merged 5 commits into
cmss13-devs:master
from
Drulikar:Elevate_Nightmare_Errors
Feb 29, 2024
Merged
Nightmare Insert Fixes & Elevated Nightmare Errors #5796
harryob
merged 5 commits into
cmss13-devs:master
from
Drulikar:Elevate_Nightmare_Errors
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Fix
Fix one bug, make ten more
Code Improvement
Make the code longer
labels
Feb 23, 2024
Update landmark names Fully remove two previously removed inserts
… (Note they were disabled from cmss13-devs#692 )
Nanu308
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mapping be fine and fly
harryob
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Improvement
Make the code longer
Fix
Fix one bug, make ten more
Mapping Approved
adds 500 new dict keys
Mapping
did you remember to save in tgm format?
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR elevates nightmare insert errors to a runtime so they fail checks and corrects errors, removes, or properly disables inserts that were causing the errors in the first place.
Explain why it's good for the game
Fixes #5558 Various nightmares were not loading because of issues; this should restore various nightmares.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek BadAtThisGame
maptweak: Fixed various nightmare inserts that were not spawning; removing or disabling others that were not in use.
maptweak: Updated containerroom_xenos insert for Solaris Ridge to include coms tower (BadAtThisGame)
code: Nightmare errors are now a runtime.
/:cl: