Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

queen unable to climbe ladges #5589

Closed
3 tasks done
cuberound opened this issue Jan 29, 2024 · 0 comments · Fixed by #5591
Closed
3 tasks done

queen unable to climbe ladges #5589

cuberound opened this issue Jan 29, 2024 · 0 comments · Fixed by #5591
Labels
Bug Admin events aren't bugs

Comments

@cuberound
Copy link
Contributor

Testmerges

#5086 #5392 #5452 #5526 #5506 #5519 #5007

Round ID

No response

Description of the bug

queen is unable to cimble ladges automaticly, unlike any other xeno

What's the difference with what should have happened?

queen should autoclimb the ledge, queen is the talles of all xenos tehrefore should have no issue climbing ladges, being forced to climbe manualy is just bad

How do we reproduce this bug?

1.be a queen
2.walk to a ladge (on kujevo for exampble but I think all ledges behave the same)
3.be forced do drag and drop to climbe it
...

Issue Bingo
@cuberound cuberound added the Bug Admin events aren't bugs label Jan 29, 2024
@SabreML SabreML mentioned this issue Jan 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 30, 2024
@SabreML
Fixes Queen xenos not automatically climbing ledges (#5591)
98520da 
# About the pull request

Makes Queen xenomorphs automatically climb ledges like normal, instead
of having to manually click+drag their sprite onto it. (Resolves #5589)

This was done by just removing the caste's `Collide()` override, since
as far as I've been able to tell it's something left over from the old
'Charge' ability.
(When it was first added in 3b0bce5 it
had some `charge_speed` and `charge_dir` checks, then those got
commented out in 277f424, then
eventually they were removed entirely and the proc was renamed to
`Collide()` in bcfa342.)

In its current state I'm not sure that it's actually doing *anything*
other than overriding the parent procs.

# Explain why it's good for the game

I can't speak from personal experience since I actively avoid playing
Queen, but from what I've heard from others it can be really irritating
to get stuck on a ledge and have to sort of pixel hunt behind your
massive sprite in order to climb over. Especially since, as said in the
issue, a xeno as big as the Queen should really have no trouble just
stepping over it.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Made the Queen able to automatically climb ledges.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Queen xenos not automatically climbing ledges SabreML/cmss13
1 participant
@cuberound