Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Queen xenos not automatically climbing ledges #5591

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Jan 29, 2024

About the pull request

Makes Queen xenomorphs automatically climb ledges like normal, instead of having to manually click+drag their sprite onto it. (Resolves #5589)

This was done by just removing the caste's Collide() override, since as far as I've been able to tell it's something left over from the old 'Charge' ability.
(When it was first added in 3b0bce5 it had some charge_speed and charge_dir checks, then those got commented out in 277f424, then eventually they were removed entirely and the proc was renamed to Collide() in bcfa342.)

In its current state I'm not sure that it's actually doing anything other than overriding the parent procs.

Explain why it's good for the game

I can't speak from personal experience since I actively avoid playing Queen, but from what I've heard from others it can be really irritating to get stuck on a ledge and have to sort of pixel hunt behind your massive sprite in order to climb over. Especially since, as said in the issue, a xeno as big as the Queen should really have no trouble just stepping over it.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Made the Queen able to automatically climb ledges.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jan 29, 2024
@harryob harryob added this pull request to the merge queue Jan 30, 2024
Merged via the queue into cmss13-devs:master with commit 98520da Jan 30, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

queen unable to climbe ladges
3 participants