Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fortified defender stays fortified even when crit #5616

Closed
3 tasks done
gitbirb opened this issue Feb 1, 2024 · 0 comments · Fixed by #5641
Closed
3 tasks done

Fortified defender stays fortified even when crit #5616

gitbirb opened this issue Feb 1, 2024 · 0 comments · Fixed by #5641
Labels
Bug Admin events aren't bugs

Comments

@gitbirb
Copy link

gitbirb commented Feb 1, 2024 •
edited
Loading

Testmerges

#5086: 'Adds the XM51 Breaching Scattergun' by VileBeggar at commit 1a300ef #5392: 'Yautja Weapon Gimmicks, Round Two' by realforest2001 at commit bcd8b2b #5007: 'Project ARES TM Holder (v4)' by realforest2001 at commit 2faf3fb

Round ID

No response

Description of the bug

If you are a defender and know you are about to go to critical condition, you can fortify. This will lead to your crit body being fortified, even though you are in crit.

This is very exploitable, and seems unintended.

What's the difference with what should have happened?

You should not stay fortified while in crit.

How do we reproduce this bug?

  1. Be defender
  2. Fortify on low health
  3. Get sent to crit
  4. Even while in crit, you are still fortified.
    ...

Issue Bingo
@gitbirb gitbirb added the Bug Admin events aren't bugs label Feb 1, 2024
@gitbirb gitbirb changed the title Crit fortified defender stays fortified Fortified defender stays fortified even when crit Feb 1, 2024
@Vicacrov Vicacrov mentioned this issue Feb 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 5, 2024
@Vicacrov
Fixes Defenders staying Fortified while being in critical state (#5641)
d5dd598 
# About the pull request

Defenders who use Fortify and then get into critical are not pullable,
because Fortify is still technically active on them. Fortify only
automatically toggles itself off upon death. This PR changes it so the
Fortify ability gets turned off upon entering critical state, making
other xenos/yautja/synths able to pull them while they are downed.

Fixes #5616 

It also adds xeno crit comsig for other possible uses. I _think_ my
signal is only called once, when the xeno enters critical, but I may
have misread the code.

# Explain why it's good for the game

Fortified defenders are anchored until they are healed (and then they
manually turn it off) or until they die. This is probably unintended
behaviour, they are not conscious anymore to be fortified.

# Testing Photographs and Procedure

Spawned a defender, fortified, dealt it 500+ damage, then tried to drag
it. Video:

<details>
<summary>Screenshots & Videos</summary>


https://github.com/cmss13-devs/cmss13/assets/49321394/335f4d39-970d-4e90-a47b-801a152d8c37

</details>


# Changelog

:cl:
fix: Fixes Defenders staying Fortified in critical state - Fortify now
automatically toggles itself off upon the Defender getting critted.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Defenders staying Fortified while being in critical state Vicacrov/cmss13
1 participant
@gitbirb