Fixes Defenders staying Fortified while being in critical state #5641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrabang
reviewed
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Defenders who use Fortify and then get into critical are not pullable, because Fortify is still technically active on them. Fortify only automatically toggles itself off upon death. This PR changes it so the Fortify ability gets turned off upon entering critical state, making other xenos/yautja/synths able to pull them while they are downed.
Fixes #5616
It also adds xeno crit comsig for other possible uses. I think my signal is only called once, when the xeno enters critical, but I may have misread the code.
Explain why it's good for the game
Fortified defenders are anchored until they are healed (and then they manually turn it off) or until they die. This is probably unintended behaviour, they are not conscious anymore to be fortified.
Testing Photographs and Procedure
Spawned a defender, fortified, dealt it 500+ damage, then tried to drag it. Video:
Screenshots & Videos
jgW4AQ1IHH.mp4
Changelog
🆑
fix: Fixes Defenders staying Fortified in critical state - Fortify now automatically toggles itself off upon the Defender getting critted.
/:cl: