Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial rooms spawn right next to each other #5700

Closed
2 of 3 tasks
Vicacrov opened this issue Feb 11, 2024 · 5 comments · Fixed by #5165
Closed
2 of 3 tasks

Tutorial rooms spawn right next to each other #5700

Vicacrov opened this issue Feb 11, 2024 · 5 comments · Fixed by #5165
Labels
Bug Admin events aren't bugs Needs Reproducing We're not even sure if you know how to do it

Comments

@Vicacrov
Copy link
Contributor

Testmerges

#5007 #5392 #5552 #5628

Round ID

20829

Description of the bug

There were three tutorials running: basic xeno tutorial, basic marine tutorial, and the basic self-healing tutorial (I forgor their proper names).

The basic marine tutorial with the gun usage was running west of this xeno tutorial. After the room despawned, the wall between the two tutorials also despawned, letting the drone go into spess exploration.

image

What's the difference with what should have happened?

There should be one space tile between tutorial rooms.

How do we reproduce this bug?

  1. Start multiple tutorials (with different room sizes?)
  2. Observe RNG doing bad things

Issue Bingo

@Vicacrov Vicacrov added the Bug Admin events aren't bugs label Feb 11, 2024
@Zonespace27
Copy link
Contributor

Likely a bug w/ turf reservations, no tutorial expands beyond its allocated size

@SabreML
Copy link
Member

SabreML commented Feb 12, 2024

I think I saw someone say that #5165 would fix this issue, although it's gone stale.

@Huffie56
Copy link
Contributor

is the PR above fixed it?

@Huffie56 Huffie56 added the Needs Reproducing We're not even sure if you know how to do it label Feb 24, 2024
@SabreML
Copy link
Member

SabreML commented Feb 24, 2024

is the PR above fixed it?

Yep, looks like it's fixed now.

@Zonespace27
Copy link
Contributor

Resolved by #5165

@Zonespace27 Zonespace27 linked a pull request Feb 24, 2024 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs Needs Reproducing We're not even sure if you know how to do it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants