Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burrower acid triggering through alamo landing on LZ through alamo flooring. #5798

Closed
3 tasks done
HaultyAnonie opened this issue Feb 24, 2024 · 0 comments · Fixed by #5820
Closed
3 tasks done

Burrower acid triggering through alamo landing on LZ through alamo flooring. #5798

HaultyAnonie opened this issue Feb 24, 2024 · 0 comments · Fixed by #5820
Labels
Bug Admin events aren't bugs

Comments

@HaultyAnonie
Copy link
Contributor

Testmerges

#5007: 'Project ARES TM Holder (v4)' by realforest2001 at commit 6c41b6a #5401: 'M540-A Armored Recon Carrier' by Zonespace27 at commit 90d7aba #5777: 'Relay Ping Browser' by Drulikar at commit 336ae65

Round ID

No response

Description of the bug

Burrower acid traps on the LZ can down marines inside through the alamo floor when the alamo lands on the LZ

What's the difference with what should have happened?

Not this.

How do we reproduce this bug?

Burrower acid traps on the LZ can down marines inside through the alamo floor when the alamo lands on the LZ

Issue Bingo

@HaultyAnonie HaultyAnonie added the Bug Admin events aren't bugs label Feb 24, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 1, 2024
# About the pull request

Nullspaces traps when they get shuttlecrushed.

Currently, if traps get shuttlecrushed, huggers/acid appear on the
dropship, instead of them simply getting deleted.

This might be a godawful way to do it, but this seemed the cleanest
solution to me. Fixes #5798

# Explain why it's good for the game

Shuttlecrushing should properly delete objects below them, it just
happens that hugger/acid traps forcibly trigger upon `Destroy()`.

# Testing Photographs and Procedure
Hugger and acid traps getting shuttlecrushed:

<details>
<summary>Screenshots & Videos</summary>



https://github.com/cmss13-devs/cmss13/assets/49321394/87540656-59b1-4299-aa73-b630b72dc1b1



</details>


# Changelog

:cl:
fix: Hugger and acid traps no longer activate when they get
shuttlecrushed.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant