Cannot remove NVG HUD insert from some helmet(s)

[dadlips]

Testmerges

N/A

Round ID

21019

Description of the bug

When attempting to screwdriver some helmets to remove the HUD, the message about the slot being reserved for headgear accessories plays. I'm guessing this is something to do with #5573. I tried putting a helmet accessory into the slot, but could not and got the same message.

What's the difference with what should have happened?

Screwdrivering a helmet should drop the HUD instead of trying to insert the screwdriver as an accessory

How do we reproduce this bug?

1. Screwdriver a helmet to remove your HUD (not sure which ones are effected)
2. You try to insert the screwdriver into the helmet instead of removing the HUD.

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[private-tristan]

MARSOC SOF helmets have inbuilt infinite NVG huds, not meant to be removable, the same way that squad optics can't be removed.

cmss13/code/modules/clothing/head/helmet.dm

Line 967 in 159bc59

built_in_visors = list(new /obj/item/device/helmet_visor/night_vision/marine_raider, new /obj/item/device/helmet_visor/security)

[SabreML]

MARSOC SOF helmets have inbuilt infinite NVG huds, not meant to be removable, the same way that squad optics can't be removed.

Yep, looks like this is what's happening. Not a bug, although I will make a PR to change the failure message when this happens since it's a bit confusing.