Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Slightly) Less confusing failure message for built-in visors #5804

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Feb 24, 2024

About the pull request

Resolves #5799 by adding a failure message when trying to remove a built-in helmet visor.

Explain why it's good for the game

Slightly less confusing for players.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: Added a failure message when trying to remove a built-in helmet visor.
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Feb 24, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a better way, but ultimately because of the need to not have a message when there's 0 built in it wouldn't be less lines. So fine as is.

@Drulikar Drulikar added this pull request to the merge queue Feb 26, 2024
Merged via the queue into cmss13-devs:master with commit 405037d Feb 26, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot remove NVG HUD insert from some helmet(s)
2 participants